-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libs dependency #2775
base: main
Are you sure you want to change the base?
Update libs dependency #2775
Changes from 6 commits
b4abdb4
004df91
9f97f75
2513650
bd80f2b
4622c52
eb049c4
98d83e7
1d74d13
fe700ed
d2102b2
589be29
b9a4264
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -4,18 +4,18 @@ go 1.23.4 | |||||||||||||
|
||||||||||||||
replace ( | ||||||||||||||
github.com/envoyproxy/protoc-gen-validate => github.com/envoyproxy/protoc-gen-validate v1.1.0 | ||||||||||||||
github.com/goccy/go-json => github.com/goccy/go-json v0.10.3 | ||||||||||||||
github.com/goccy/go-json => github.com/goccy/go-json v0.10.4 | ||||||||||||||
github.com/golang/protobuf => github.com/golang/protobuf v1.5.4 | ||||||||||||||
github.com/kpango/glg => github.com/kpango/glg v1.6.15 | ||||||||||||||
github.com/pkg/sftp => github.com/pkg/sftp v1.13.7 | ||||||||||||||
golang.org/x/crypto => golang.org/x/crypto v0.30.0 | ||||||||||||||
golang.org/x/net => golang.org/x/net v0.32.0 | ||||||||||||||
golang.org/x/crypto => golang.org/x/crypto v0.31.0 | ||||||||||||||
golang.org/x/net => golang.org/x/net v0.33.0 | ||||||||||||||
golang.org/x/text => golang.org/x/text v0.21.0 | ||||||||||||||
google.golang.org/genproto => google.golang.org/genproto v0.0.0-20241209162323-e6fa225c2576 | ||||||||||||||
google.golang.org/genproto/googleapis/api => google.golang.org/genproto/googleapis/api v0.0.0-20241209162323-e6fa225c2576 | ||||||||||||||
google.golang.org/genproto/googleapis/rpc => google.golang.org/genproto/googleapis/rpc v0.0.0-20241209162323-e6fa225c2576 | ||||||||||||||
google.golang.org/grpc => google.golang.org/grpc v1.68.1 | ||||||||||||||
google.golang.org/protobuf => google.golang.org/protobuf v1.35.2 | ||||||||||||||
google.golang.org/genproto => google.golang.org/genproto v0.0.0-20241216192217-9240e9c98484 | ||||||||||||||
google.golang.org/genproto/googleapis/api => google.golang.org/genproto/googleapis/api v0.0.0-20241216192217-9240e9c98484 | ||||||||||||||
google.golang.org/genproto/googleapis/rpc => google.golang.org/genproto/googleapis/rpc v0.0.0-20241216192217-9240e9c98484 | ||||||||||||||
google.golang.org/grpc => google.golang.org/grpc v1.69.2 | ||||||||||||||
google.golang.org/protobuf => google.golang.org/protobuf v1.36.0 | ||||||||||||||
gopkg.in/yaml.v3 => gopkg.in/yaml.v3 v3.0.1 | ||||||||||||||
sigs.k8s.io/yaml => sigs.k8s.io/yaml v1.4.0 | ||||||||||||||
) | ||||||||||||||
|
@@ -33,10 +33,10 @@ require ( | |||||||||||||
github.com/goccy/go-json v0.10.2 // indirect | ||||||||||||||
github.com/kpango/fastime v1.1.9 // indirect | ||||||||||||||
github.com/planetscale/vtprotobuf v0.6.1-0.20240319094008-0393e58bdf10 // indirect | ||||||||||||||
golang.org/x/net v0.29.0 // indirect | ||||||||||||||
golang.org/x/net v0.30.0 // indirect | ||||||||||||||
golang.org/x/sys v0.28.0 // indirect | ||||||||||||||
golang.org/x/text v0.21.0 // indirect | ||||||||||||||
google.golang.org/genproto/googleapis/api v0.0.0-20240903143218-8af14fe29dc1 // indirect | ||||||||||||||
google.golang.org/genproto/googleapis/rpc v0.0.0-20241206012308-a4fef0638583 // indirect | ||||||||||||||
google.golang.org/protobuf v1.35.2 // indirect | ||||||||||||||
google.golang.org/genproto/googleapis/api v0.0.0-20241015192408-796eee8c2d53 // indirect | ||||||||||||||
google.golang.org/genproto/googleapis/rpc v0.0.0-20241209162323-e6fa225c2576 // indirect | ||||||||||||||
google.golang.org/protobuf v1.36.0 // indirect | ||||||||||||||
Comment on lines
+39
to
+41
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix version mismatch in genproto dependencies There's a version mismatch between replace and require directives for
This inconsistency should be resolved to prevent potential version resolution conflicts. Apply this diff to align the versions: -google.golang.org/genproto/googleapis/rpc v0.0.0-20241209162323-e6fa225c2576 // indirect
+google.golang.org/genproto/googleapis/rpc v0.0.0-20241216192217-9240e9c98484 // indirect 📝 Committable suggestion
Suggested change
|
||||||||||||||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Based on the analysis of the shell script outputs, I can now generate the final response:
Review dependency updates with security considerations
The dependency updates require attention in the following areas:
grpc.WithInsecure()
that should be updated:hack/benchmark/e2e/agent/core/ngt/ngt_bench_test.go
pkg/agent/core/ngt/service/ngt_test.go
tests/e2e/performance/max_vector_dim_test.go
Please update the test files to use the newer
insecure.NewCredentials()
instead of the deprecatedgrpc.WithInsecure()
when upgrading to gRPC v1.69.0.🔗 Analysis chain
Verify breaking changes in critical dependency updates
Several security-critical dependencies have been updated:
golang.org/x/crypto
: v0.31.0google.golang.org/grpc
: v1.69.0google.golang.org/protobuf
: v1.36.0Also applies to: 11-11, 14-18
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 112332
Script:
Length of output: 67525
Script:
Length of output: 3235