Backport PR #2765 to release/v1.7 for Change make command #2770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vankichi <[email protected]>
Deploying vald with
|
| Latest commit: |
c832654
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://20a478d1.vald.pages.dev |
| Branch Preview URL: | https://backport-release-v1-7-ci-wor-ykr4.vald.pages.dev |
📝 WalkthroughWalkthroughThe changes in this pull request involve modifications to a GitHub Actions workflow configuration file, specifically targeting Docker image scanning. The primary alteration is the renaming of the job target from Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (2).github/workflows/dockers-image-scan.yaml (2)
The change from
Let's verify that the new target name ✅ Verification successfulTarget name change is consistent with the codebase The change from
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for Docker image naming consistency across the codebase
# Search for Docker image references in Dockerfiles, Helm charts, and deployment files
echo "Searching for Docker image references..."
rg -g '!{.git,vendor}' -i 'helm-operator|operator/helm'
# Check Helm charts specifically
fd -g '**/values.yaml' -x cat {} \; | grep -i "image:"
Length of output: 75521 Script: #!/bin/bash
# Let's verify the Docker image naming consistency by checking:
# 1. The helm-operator image references in Dockerfiles
# 2. The actual image used in deployment manifests
# 3. The image tag format in CI/CD workflows
# Check Dockerfile references
echo "=== Checking Dockerfile references ==="
rg -g 'Dockerfile*' 'helm-operator'
# Check deployment manifests
echo -e "\n=== Checking deployment manifests ==="
rg -g '*.yaml' -g '*.yml' 'image:.*helm-operator'
# Check CI/CD workflow references
echo -e "\n=== Checking CI/CD workflow references ==="
rg -g '.github/workflows/*' 'helm-operator'
Length of output: 1373 Script: #!/bin/bash
# Let's check the CI/CD workflow files specifically for helm-operator references
# and verify the target name consistency
echo "=== Checking workflow files ==="
find .github/workflows -type f -name "*.yaml" -o -name "*.yml" -exec grep -l "helm-operator\|operator/helm" {} \;
echo -e "\n=== Checking target name usage ==="
find .github/workflows -type f -name "*.yaml" -o -name "*.yml" -exec grep -A2 -B2 "target:" {} \;
Length of output: 377 Script: #!/bin/bash
# Let's do a more comprehensive check of the workflow file
echo "=== Checking dockers-image-scan.yaml content ==="
cat .github/workflows/dockers-image-scan.yaml
echo -e "\n=== Checking related files for helm-operator references ==="
# Search in workflow and Docker-related files
rg -g '!{.git,vendor}' -g '*.{yaml,yml,Dockerfile}' -C 3 'operator/helm|helm-operator'
Length of output: 19603 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
[CHATOPS:HELP] ChatOps commands.
|
vankichi
approved these changes
Dec 11, 2024
vankichi
deleted the
backport/release/v1.7/ci/workflow/fix-failed-workflow
branch
This was referenced Dec 11, 2024
This was referenced Dec 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SSIA
Related Issue
Versions
Checklist
Special notes for your reviewer
Summary by CodeRabbit