Backport PR #2611 to release/v1.7 for Fix broken links in the document files #2614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 🐛 📝 Fix broken links in document files Signed-off-by: vankichi <[email protected]> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 07bb715 according to the output from Gofumpt and Prettier. Details: #2611 --------- Signed-off-by: vankichi <[email protected]> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Deploying vald with
|
| Latest commit: |
f042347
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://20167fff.vald.pages.dev |
| Branch Preview URL: | https://backport-release-v1-7-docume-ssuo.vald.pages.dev |
WalkthroughWalkthroughThis pull request introduces several updates across multiple documentation files and Kubernetes resource definitions. Key changes include the addition of a configuration option to enable the gateway mirror feature in the Kubernetes manifest update process, updates to documentation links for improved navigation, and the introduction of various Kubernetes resources such as ConfigMaps, Deployments, and ServiceAccounts for the Vald mirror gateway. These modifications collectively enhance the deployment and documentation structure of the Vald application. Changes
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
[CHATOPS:HELP] ChatOps commands.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1407,4 +1407,4 @@ Since each package has its purpose, we decided to apply different strategies to | |||
|
|
|||
| For the rest of the `./pkg` packages, we decided to implement the unit test for the exported function only. | |||
|
|
|||
| Please follow the [unit test guideline](./unit-test-guideline.md) for more details on how to implement good unit test. | |||
| Please follow the [unit test guideline](../unit-test-guideline.md) for more details on how to implement good unit test. | |||
There was a problem hiding this comment.
🚫 [documents testlint] <eslint.rules.write-good> reported by reviewdog 🐶
"implement" is wordy or unneeded (write-good)
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
…docs-k8s/fix-broken-links
vankichi
deleted the
backport/release/v1.7/documentation/docs-k8s/fix-broken-links
branch
This was referenced Sep 12, 2024
2 tasks
This was referenced Oct 1, 2024
This was referenced Oct 9, 2024
Merged
Merged
2 tasks
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have fixed the broken links in the document files.
According to fixing, I realized
k8s/gateway/mirroris missing even though their links are written in the document file.So, I have updated
Makefile.d/k8s.mkto generatek8s/gateway/mirror.Related Issue
Versions
Checklist
Special notes for your reviewer
Summary by CodeRabbit
New Features
vald-mirror-gateway.Documentation
Style