Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sed applying line #2488

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fix sed applying line #2488

merged 1 commit into from
Apr 30, 2024

Conversation

kmrmt
Copy link
Contributor

@kmrmt kmrmt commented Apr 26, 2024 •
edited by coderabbitai bot
Loading

Description

fix applying line for sed command because of adding file header

Related Issue

Versions

  • Go Version: 1.22.2
  • Rust Version: 1.77.2
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.29.3
  • NGT Version: 2.2

Checklist

Special notes for your reviewer

Summary by CodeRabbit

  • Chores
    • Updated a script to modify the Rust version in a configuration file, ensuring compatibility with the latest dependencies.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 26, 2024 •
edited
Loading

Walkthrough

Walkthrough

The update primarily adjusts a sed command in a Makefile to target a different line in the Rust toolchain configuration file. This change reflects a shift in how the Rust version is specified, ensuring the correct line is modified to match the desired Rust version.

Changes

File Path Change Summary
Makefile.d/.../dependencies.mk Updated sed command to change Rust version on line 17 instead of line 2.

Poem

🐇🌟
In the land of code, where the rusty tools lie,
A hop, a skip, a command line fly.
From line two to seventeen, a leap so bold,
To update the versions in tales untold.
Cheers to changes, small but mighty,
Signed with a thump, by your CodeRabbit, sprightly!
🌟🐇

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 9c12b90 and fe98979.
Files selected for processing (1)
  • Makefile.d/dependencies.mk (1 hunks)
Additional comments not posted (1)
Makefile.d/dependencies.mk (1)

88-88: The updated sed command correctly targets the new line number and matches the expected version pattern. This change ensures that the Rust version is set appropriately in the rust-toolchain.toml file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kmrmt kmrmt requested review from a team, kpango, vankichi, hlts2 and datelier and removed request for a team, vankichi and kpango April 26, 2024 07:48
hlts2
hlts2 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kmrmt kmrmt merged commit fe962e4 into main Apr 30, 2024
35 checks passed
@kmrmt kmrmt deleted the bugfix/rust/fix-update-command branch April 30, 2024 04:33
@github-actions github-actions bot mentioned this pull request May 1, 2024
Closed
hlts2 added a commit that referenced this pull request May 8, 2024
@hlts2 @vdaas-ci
@deepsource-autofix @ykadowak @kpango @kmrmt @vankichi @taisuou @aknishid @takuyaymd @allcontributors @hrichiksite
Sync release/v1.7 to main (#2495)
a698f3f 
* fix: git add chart directory for release (#2356)

Signed-off-by: hlts2 <[email protected]>

* 🔖 🤖 Release v1.7.11 (#2360) (#2361)

* 🔖 🤖 Release v1.7.11



* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in 578746e according to the output
from Gofumpt and Prettier.

Details: #2360

---------

Signed-off-by: Vdaas CI <[email protected]>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>

* Change docker scan timeout longer (#2363)

* refactor code using golangci-lint (#2362)

Signed-off-by: kpango <[email protected]>

* Create SECURITY.md (#2367)

* Create SECURITY.md

Signed-off-by: Yusuke Kato <[email protected]>

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in e8609b0 according to the output
from Gofumpt and Prettier.

Details: #2367

---------

Signed-off-by: Yusuke Kato <[email protected]>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>

* add commit hash build image (#2359)

Signed-off-by: kpango <[email protected]>

* Make agent export index metrics to Pod k8s resource (#2319)

* Add config

* Add clusterRole and serviceAccount for agent

* Add more metrics

* Format

* Add export index info duration configuration

* Refactor internal/k8s

* Move apply function to internal/k8s

* Add more config

* Remove unused import and variable

* Use vald errors

* Add pod name and pod namespace to hack e2e agent

* Apply tagalign

* Revert unnecesarry specification of PodName

* Enable export index info to Kubernetes in agent templates only when the config is enabled

* Fix agent clusterrole name

* Update key name

* Update comments

* Add index count as export metrics

* Ignore gomnd

* Add index count entry to exportMetricsOnCreateIndex function

* Update values schema

* Fix formatter job

* Remove unused defines

* update docker build target platform selection rules (#2370)

Signed-off-by: kpango <[email protected]>
Co-authored-by: Yusuke Kadowaki <[email protected]>

* improve Backport Pull Request Title & Description Quality (#2373)

Signed-off-by: kpango <[email protected]>
Co-authored-by: Kosuke Morimoto <[email protected]>

* Update workflow to release readreplica chart (#2383)

* improve Backport Pull Request Title & Description Quality (#2373)

Signed-off-by: kpango <[email protected]>
Co-authored-by: Kosuke Morimoto <[email protected]>

* Add readreplica chart release

* update k8s/readreplica

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in 70f1dad according to the output
from Gofumpt and Prettier.

Details: #2383

* [bugfix] fix backport github value bypass failure (#2378)

Signed-off-by: kpango <[email protected]>

* Revert backport.yaml

---------

Signed-off-by: kpango <[email protected]>
Co-authored-by: Yusuke Kato <[email protected]>
Co-authored-by: Kosuke Morimoto <[email protected]>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>

* 💚 ♻️ Add Con-Bench helm chart to the Vald charts (#2388)

Signed-off-by: vankichi <[email protected]>

* Delete unnecessary code for mirror (#2366)

* fix: delete unnecessary code for mirror

Signed-off-by: hlts2 <[email protected]>

* fix: make deps/install and format

Signed-off-by: hlts2 <[email protected]>

* improve Backport Pull Request Title & Description Quality (#2373)

Signed-off-by: kpango <[email protected]>
Co-authored-by: Kosuke Morimoto <[email protected]>

* fix: naming of variable

Signed-off-by: hlts2 <[email protected]>

---------

Signed-off-by: hlts2 <[email protected]>
Signed-off-by: kpango <[email protected]>
Co-authored-by: Yusuke Kato <[email protected]>
Co-authored-by: Kosuke Morimoto <[email protected]>

* change JP logo to EN logo (#2369)

Signed-off-by: kpango <[email protected]>
Co-authored-by: taisuou <[email protected]>

* Add rotate-all option to rotator (#2305)

* Add rotate-all option to rotator

* Fix linter warnings

* Make it possible to choose multiple rotation target

* Add tests for parseReplicaID

* Add tests for parseReplicaID

* Hide testify in internal

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in dd84674 according to the output
from Gofumpt and Prettier.

Details: #2305

* Apply format

* Lint

* Lint

---------

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Kato <[email protected]>

* Resolve kvs already closed before last saving (#2390)

Signed-off-by: kpango <[email protected]>

* create continous benchmark doc (#2352)

* improve Backport Pull Request Title & Description Quality (#2373)

Signed-off-by: kpango <[email protected]>
Co-authored-by: Kosuke Morimoto <[email protected]>

* 📝 create continous benchmark doc

Signed-off-by: vankichi <[email protected]>

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in ace001a according to the output
from Gofumpt and Prettier.

Details: #2352

* ♻️ rafactor default params

Signed-off-by: vankichi <[email protected]>

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in 9880dfc according to the output
from Gofumpt and Prettier.

Details: #2352

* ♻️ Fix format

Signed-off-by: vankichi <[email protected]>

* Revert "improve Backport Pull Request Title & Description Quality (#2373)"

This reverts commit 4246def.

* ♻️ remove dimension from con-bench

Signed-off-by: vankichi <[email protected]>

* 📝 Add sample benchmark manifest

Signed-off-by: vankichi <[email protected]>

* Update docs/performance/continuos-benchmatk.md

Co-authored-by: Yusuke Kato <[email protected]>
Signed-off-by: Kiichiro YUKAWA <[email protected]>

* Update docs/performance/continuos-benchmatk.md

Co-authored-by: Hiroto Funakoshi <[email protected]>
Signed-off-by: Kiichiro YUKAWA <[email protected]>

---------

Signed-off-by: kpango <[email protected]>
Signed-off-by: vankichi <[email protected]>
Signed-off-by: Kiichiro YUKAWA <[email protected]>
Co-authored-by: Yusuke Kato <[email protected]>
Co-authored-by: Kosuke Morimoto <[email protected]>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Hiroto Funakoshi <[email protected]>

* fix: build error of internal kvs test (#2396)

Signed-off-by: hlts2 <[email protected]>

* 🤖 Update license headers / Format Go codes and YAML files (#2397)

Signed-off-by: Vdaas CI <[email protected]>
Co-authored-by: Hiroto Funakoshi <[email protected]>

* fix: disable protobuf dispatch for client (#2401)

Signed-off-by: hlts2 <[email protected]>

* update deps (#2404)

Signed-off-by: kpango <[email protected]>

* 🔖 🤖 Release v1.7.12 (#2408) (#2409)

* 🔖 🤖 Release v1.7.12



* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in 5bd8605 according to the output
from Gofumpt and Prettier.

Details: #2408

---------

Signed-off-by: Vdaas CI <[email protected]>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>

* Add tests for index information export (#2412)

* Add tests for index information export

* Add comments

* 📝 Fix typo of file name (#2413)

Signed-off-by: vankichi <[email protected]>

* Fix agent-faiss build failed (#2418)

* 🐳 Fix agent-faiss build failed

Signed-off-by: vankichi <[email protected]>

* 🐳 Fix COPY binary

Signed-off-by: vankichi <[email protected]>

* 🐳 Change COPY binary (use ld-linux-x86-64)

Signed-off-by: vankichi <[email protected]>

---------

Signed-off-by: vankichi <[email protected]>

* Fix the logic to determine docker image (#2410)

* fix: update action to get tag list

Signed-off-by: hlts2 <[email protected]>

* fix: refactor sub command execution

Signed-off-by: hlts2 <[email protected]>

* fix: use tag list in detect ci container workflow

Signed-off-by: hlts2 <[email protected]>

* fix: name for detected result

Signed-off-by: hlts2 <[email protected]>

* fix: invalid variable bug

Signed-off-by: hlts2 <[email protected]>

* fix: execution error and invalid variable

Signed-off-by: hlts2 <[email protected]>

* fix: deleted unnecessary comment

Signed-off-by: hlts2 <[email protected]>

* fix: deleted unnecessary parameters

Signed-off-by: hlts2 <[email protected]>

* fix: use new determine tag logic in the docker build workflow

Signed-off-by: hlts2 <[email protected]>

* fix: bugfix extra tags handling and small refactor

Signed-off-by: hlts2 <[email protected]>

* fix: build tag rule or release branch based on tag list

Signed-off-by: hlts2 <[email protected]>

* fix: typo

Signed-off-by: hlts2 <[email protected]>

* fix: indent

Signed-off-by: hlts2 <[email protected]>

* fix: refactor syntax

Signed-off-by: hlts2 <[email protected]>

* fix: typo and invalid option error

Signed-off-by: hlts2 <[email protected]>

* fix: use helm extra option

Signed-off-by: hlts2 <[email protected]>

* fix: add comment for tag management

Signed-off-by: hlts2 <[email protected]>

* fix: unsetbug of helm extra option

Signed-off-by: hlts2 <[email protected]>

* fix: build target condition

Signed-off-by: hlts2 <[email protected]>

---------

Signed-off-by: hlts2 <[email protected]>

* Update build rule for nightly image (#2421)

* fix: update build rule for nightly

Signed-off-by: hlts2 <[email protected]>

* fix: indent and deleted unnecessary tag

Signed-off-by: hlts2 <[email protected]>

* fix: update tag name when tag is unknown

Signed-off-by: hlts2 <[email protected]>

* fix: add secondary tags for build performance

Signed-off-by: hlts2 <[email protected]>

* fix: argument order

Signed-off-by: hlts2 <[email protected]>

---------

Signed-off-by: hlts2 <[email protected]>

* Add `index-operator` template implementation (#2375)

* improve Backport Pull Request Title & Description Quality (#2373)

Signed-off-by: kpango <[email protected]>
Co-authored-by: Kosuke Morimoto <[email protected]>

* [bugfix] fix backport github value bypass failure (#2378)

Signed-off-by: kpango <[email protected]>

* [bugfix] fix backport github value bypass failure (#2381)

Signed-off-by: kpango <[email protected]>

* Add index operator boilerplate

* Add k8s controller

* Add pod and job controllers

* Add annotations in the pod reconciler

* Update auto indexing service configurations

* Update WithOnReconcileFunc signature to include context

* Refactor debugging log

* Refactor reconcile funcs

* add nolint

* remove unused parameters

* lint

* Add dockerfile and build ci

* remove params

* Add index-operator image build command to Makefile

* Add index operator k8s templates

* Update helm schema

* Update readme

* Add internal/k8s as a trigger for images that depends on controller-runtime

* remove comment

* Update pkg/index/operator/service/operator.go

Co-authored-by: Yusuke Kato <[email protected]>
Signed-off-by: Yusuke Kadowaki <[email protected]>

* Update pkg/index/operator/service/operator.go

Co-authored-by: Yusuke Kato <[email protected]>
Signed-off-by: Yusuke Kadowaki <[email protected]>

* Refactor

* Add build commands

* Refactor

Co-authored-by: Yusuke Kato <[email protected]>

---------

Signed-off-by: kpango <[email protected]>
Signed-off-by: Yusuke Kadowaki <[email protected]>
Co-authored-by: Yusuke Kato <[email protected]>
Co-authored-by: Kosuke Morimoto <[email protected]>

* Fix output settings to determine-docker-image-tag action and release branch build tag name (#2423)

* fix: add outut settings for action

Signed-off-by: hlts2 <[email protected]>

* fix: tag name for release branch build

Signed-off-by: hlts2 <[email protected]>

* fix: refactor

Signed-off-by: hlts2 <[email protected]>

---------

Signed-off-by: hlts2 <[email protected]>

* fix: typo of execution rule (#2426)

Signed-off-by: hlts2 <[email protected]>

* Add flush API for deleting all vectors (#2273)

* add flush api

Signed-off-by: aknishid <[email protected]>

* added flush api

* fix typo

* fix pb.go & fix conflict

Signed-off-by: aknishid <[email protected]>

* add flush api

* add handler Flush

Signed-off-by: aknishid <[email protected]>

* add vald.Client flush

* fix filter gateway

Signed-off-by: aknishid <[email protected]>

* fix handler cnts

Signed-off-by: aknishid <[email protected]>

* delete unused var

Signed-off-by: aknishid <[email protected]>

* add author

Signed-off-by: Yamada Takuya <[email protected]>

* fix error

Signed-off-by: aknishid <[email protected]>

* fix flush.go & ngt.go

Signed-off-by: aknishid <[email protected]>

* add flush to example

Signed-off-by: aknishid <[email protected]>

* fix gateway lb

Signed-off-by: aknishid <[email protected]>

* update flush proto

Signed-off-by: aknishid <[email protected]>

* fix docs api README.md

Signed-off-by: aknishid <[email protected]>

* Fix flush ctx

Signed-off-by: aknishid <[email protected]>

* update docs & comment

Signed-off-by: aknishid <[email protected]>

* after make format

Signed-off-by: aknishid <[email protected]>

* add e2e

Signed-off-by: aknishid <[email protected]>

* update example & tutorial

Signed-off-by: aknishid <[email protected]>

* Update internal/errors/ngt.go

Co-authored-by: Kiichiro YUKAWA <[email protected]>

* fix review

Signed-off-by: aknishid <[email protected]>

* modify status.md

Signed-off-by: aknishid <[email protected]>

* add error handling

Signed-off-by: aknishid <[email protected]>

* update proto

Signed-off-by: aknishid <[email protected]>

* fix doc

Signed-off-by: aknishid <[email protected]>

* ♻️ Fix proto

Signed-off-by: vankichi <[email protected]>

* use atomic bool

Signed-off-by: aknishid <[email protected]>

* fix proto

Signed-off-by: aknishid <[email protected]>

* update proto

Signed-off-by: aknishid <[email protected]>

* fix gateway error

Signed-off-by: aknishid <[email protected]>

* ✅ 🚧 Avoid e2e failing due to unimplemented handler and Add unimplmented handler method for the future

Signed-off-by: vankichi <[email protected]>

* Update apis/proto/v1/payload/payload.proto

Co-authored-by: Kiichiro YUKAWA <[email protected]>
Signed-off-by: aknishid <[email protected]>

---------

Signed-off-by: aknishid <[email protected]>
Signed-off-by: Yamada Takuya <[email protected]>
Signed-off-by: vankichi <[email protected]>
Signed-off-by: aknishid <[email protected]>
Co-authored-by: takuyaymd <[email protected]>
Co-authored-by: takuyyam <[email protected]>
Co-authored-by: Kiichiro YUKAWA <[email protected]>
Co-authored-by: Yusuke Kato <[email protected]>

* docs: add aknishid as a contributor for code, and maintenance (#2431)

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in abc4c52 according to the output
from Gofumpt and Prettier.

Details: #2431

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Kato <[email protected]>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>

* update deps & add validation for Flush API when agent is Read Only (#2433)

Signed-off-by: kpango <[email protected]>

* Update README.md (grammer) (#2440)

Signed-off-by: Hrichik Mazumder <[email protected]>

* docs: add hrichiksite as a contributor for doc (#2441)

* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in b8054d9 according to the output
from Gofumpt and Prettier.

Details: #2441

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Kato <[email protected]>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>

* Added snapshot timestamp annotations to read replica agent (#2428)

* Add lastTimeRotateReplicaTimestampAnnotationsKey constant

* Use ptr package

* Update annotations in ngt.go and rotator.go

* Add labels to Pod struct and update annotations handling***

***Introduce vald package for k8s related constants***

***Implement rotateIfNeeded function to check if read replica rotation is needed

* Refactor

* set sample log level debug

* Use k8s timestamp

* Refactor

* Format

* Add MatchingLabels method to ValdK8sClientMock

* Format

* Fix test

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in 39b66fa according to the output
from Gofumpt and Prettier.

Details: #2428

* Rename constants

Co-authored-by: Yusuke Kato <[email protected]>

* Refactor rotateIfNeeded function to use label selector for listing deployments

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in 6ace761 according to the output
from Gofumpt and Prettier.

Details: #2428

* FIx deepsource

* Revert

---------

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Kato <[email protected]>

* fix: bugfix version update for docker build (#2445)

Signed-off-by: hlts2 <[email protected]>

* Fix index job logic to pass DNS A record (#2438)

* fix: choose user given target address in priority

Signed-off-by: hlts2 <[email protected]>

* fix: deleted unnecessary code

Signed-off-by: hlts2 <[email protected]>

* fix: add logic to connect the user given target addresses

Signed-off-by: hlts2 <[email protected]>

* fix: add info log about new connection target

Signed-off-by: hlts2 <[email protected]>

* fix: indent of configuration data

Signed-off-by: hlts2 <[email protected]>

* fix: indent bug

Signed-off-by: hlts2 <[email protected]>

* fix: deepsource warning

Signed-off-by: hlts2 <[email protected]>

---------

Signed-off-by: hlts2 <[email protected]>

* Fix operator-sdk version (#2447)

* fix: down grade operator version

Signed-off-by: hlts2 <[email protected]>

* fix: upgrade operator-sdk version

Signed-off-by: hlts2 <[email protected]>

* fix: operator-sdk version

Signed-off-by: hlts2 <[email protected]>

---------

Signed-off-by: hlts2 <[email protected]>

* add file name lint (#2417)

Signed-off-by: kpango <[email protected]>

* fix: add extra option for ci-container build (#2451)

Signed-off-by: hlts2 <[email protected]>

* Add base of benchmark operator dashboard (#2430)

* 📈 Add base of benchmark operator dashboard

Signed-off-by: vankichi <[email protected]>

* 💚 Fix build benchmark images trigger

Signed-off-by: vankichi <[email protected]>

* 💚 Add info tag for info metrics

Signed-off-by: vankichi <[email protected]>

* 📈 showing job image and tags

Signed-off-by: vankichi <[email protected]>

* 📈 add bench job status

Signed-off-by: vankichi <[email protected]>

* ♻️ Update dashboard and rename

Signed-off-by: vankichi <[email protected]>

* ♻️ Fix

Signed-off-by: vankichi <[email protected]>

* Update internal/observability/metrics/tools/benchmark/benchmark.go

Co-authored-by: Hiroto Funakoshi <[email protected]>
Signed-off-by: Kiichiro YUKAWA <[email protected]>

---------

Signed-off-by: vankichi <[email protected]>
Signed-off-by: Kiichiro YUKAWA <[email protected]>
Co-authored-by: Hiroto Funakoshi <[email protected]>

* Implement index operator logic for read replica rotation (#2444)

* Remove job reconciler

* Add leader election to index operator

* Add roles for leader election

* Add operator logic for rotation

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in 844cca1 according to the output
from Gofumpt and Prettier.

Details: #2444

* Remove unnecesary change

* Fix build

* nits

* Refactor

* Fix clusterrole

* Move to podv2

* Add job concurrency check

* Refactor

* Refactor

* Fix heavy copying

* Update helm schema

* Fix package doc

* Remove unused code and refactor For() method

* Update target read replica ID in config

* Update internal/k8s/podv2/option.go

Co-authored-by: Hiroto Funakoshi <[email protected]>
Signed-off-by: Yusuke Kadowaki <[email protected]>

* Refactor

* rename podv2 to v2/pod

* Add client DI

* Fix envkey helper

* Set namespace from values.yaml

* Use annotations to specify the id

* Update schema

* Update sample

* Update values

* Update schema

* Fix spelling

* Fix package name

* Fix read replica e2e

* Add job templates for rotation, creation, saving, and correction

* Update config.go to decode k8s object

* Update sample.yaml for index operator

* Use job template from cfg

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in 584d1f0 according to the output
from Gofumpt and Prettier.

Details: #2444

* Fix tagalign

* Fix config test

* Fix config test

* Disable read replica e2e for now

---------

Signed-off-by: Yusuke Kadowaki <[email protected]>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Hiroto Funakoshi <[email protected]>

* add inner product distance type for ngt (#2454)

Signed-off-by: kpango <[email protected]>

* Fix e2e for read replica and add e2e for index operator (#2455)

* Fix read replica e2e

* Update default image list in action.yaml

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in 6cdac9f according to the output
from Gofumpt and Prettier.

Details: #2455

---------

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>

* Add unit tests for index operator (#2460)

* Add prototype tests

* Refactor

* Fix not to use kubeconfig

* 🤖 Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2457)

Signed-off-by: Vdaas CI <[email protected]>
Co-authored-by: Kiichiro YUKAWA <[email protected]>

* Bugfix recreate benchmark job when operator reboot (#2463)

* 🐛 Fix recreate benchmark job already runnnig when operator rebooted

Signed-off-by: vankichi <[email protected]>

* 🐛 Fix benchmarkJobReconcile status handling

Signed-off-by: vankichi <[email protected]>

* ✅ Fix test

Signed-off-by: vankichi <[email protected]>

* ♻️ Update k8s dir

Signed-off-by: vankichi <[email protected]>

* ♻️ Fix

Signed-off-by: vankichi <[email protected]>

---------

Signed-off-by: vankichi <[email protected]>

* Refactor k8s types (#2462)

* Refactor types

* Refactor hdf5_test.go

* Format

* Refactor

* add extra flags for NGT build phase (#2467)

* Fix workflow trigger for backport pr creation (#2471)

* Automatically add backport main label for release-pr (#2473)

* feat: automatically add backport main label for release-pr

Signed-off-by: Hiroto Funakoshi <[email protected]>

* fix: deleted unnecessary quotation

Signed-off-by: Hiroto Funakoshi <[email protected]>

---------

Signed-off-by: Hiroto Funakoshi <[email protected]>

* update deps (#2468)

* update deps

Signed-off-by: kpango <[email protected]>

* fix server_test.go due to the grpc-go updates

Signed-off-by: kpango <[email protected]>

---------

Signed-off-by: kpango <[email protected]>

* Update README.md (#2479)

Signed-off-by: Yusuke Kato <[email protected]>

* Implement client metrics interceptor for continuous benchmark job (#2477)

* ♻️ Mount benchmark-operator-config to vald-benchmark-job Pod

Signed-off-by: vankichi <[email protected]>

* 📈 add framework for send gRPC client metrics

Signed-off-by: vankichi <[email protected]>

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in a532b7d according to the output
from Gofumpt and Prettier.

Details: #2477

* 📈 Add client metric interceptor

Signed-off-by: vankichi <[email protected]>

* ♻️ Change vbor chart for apply general job configuration

Signed-off-by: vankichi <[email protected]>

* Update pkg/tools/benchmark/job/usecase/benchmarkd.go

Co-authored-by: Hiroto Funakoshi <[email protected]>
Signed-off-by: Kiichiro YUKAWA <[email protected]>

* 🐛 Fix build error and add comment

Signed-off-by: vankichi <[email protected]>

* ♻️ Fix format

Signed-off-by: vankichi <[email protected]>

---------

Signed-off-by: vankichi <[email protected]>
Signed-off-by: Kiichiro YUKAWA <[email protected]>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Hiroto Funakoshi <[email protected]>

* implement ngt-rs and its unit test and add GitHub Actions workflows (#2478)

* implement test

* update rust dependencies

* fix

* make format

* add Github Actions workflows

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Yusuke Kato <[email protected]>

* 📈 Add client metrics panels for continuous benchmark job (#2481)

Signed-off-by: vankichi <[email protected]>

* Add rust versions (#2482)

* add rust versions

* fix

* add rust version

* add rust-toolchain.toml

* make format

* Update continuous benchmark docs (#2485)

* 📝 Update continous benchmark docs

Signed-off-by: vankichi <[email protected]>

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in e3ab1d2 according to the output
from Gofumpt and Prettier.

Details: #2485

* Update docs/performance/continuous-benchmark.md

Signed-off-by: Kiichiro YUKAWA <[email protected]>

* 📝 Fix

Signed-off-by: vankichi <[email protected]>

---------

Signed-off-by: vankichi <[email protected]>
Signed-off-by: Kiichiro YUKAWA <[email protected]>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>

* update NGT version (#2484)

* fix sed line (#2488)

* 🤖 Automatically update PULL_REQUEST_TEMPLATE and ISSUE_TEMPLATE (#2487)

Signed-off-by: Vdaas CI <[email protected]>
Co-authored-by: Hiroto Funakoshi <[email protected]>

* Add efficient search logic for large top-k users (#2491)

* add efficient search logic for large top-k users

Signed-off-by: kpango <[email protected]>

* fix bug

Signed-off-by: kpango <[email protected]>

---------

Signed-off-by: kpango <[email protected]>

---------

Signed-off-by: hlts2 <[email protected]>
Signed-off-by: Vdaas CI <[email protected]>
Signed-off-by: kpango <[email protected]>
Signed-off-by: Yusuke Kato <[email protected]>
Signed-off-by: vankichi <[email protected]>
Signed-off-by: Kiichiro YUKAWA <[email protected]>
Signed-off-by: Yusuke Kadowaki <[email protected]>
Signed-off-by: aknishid <[email protected]>
Signed-off-by: Yamada Takuya <[email protected]>
Signed-off-by: aknishid <[email protected]>
Signed-off-by: Hrichik Mazumder <[email protected]>
Signed-off-by: Hiroto Funakoshi <[email protected]>
Co-authored-by: vdaas-ci <[email protected]>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Kadowaki <[email protected]>
Co-authored-by: Yusuke Kato <[email protected]>
Co-authored-by: Kosuke Morimoto <[email protected]>
Co-authored-by: Kiichiro YUKAWA <[email protected]>
Co-authored-by: taisho <[email protected]>
Co-authored-by: taisuou <[email protected]>
Co-authored-by: aknishid <[email protected]>
Co-authored-by: takuyaymd <[email protected]>
Co-authored-by: takuyyam <[email protected]>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Hrichik Mazumder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlts2 hlts2 hlts2 approved these changes

@kpango kpango kpango approved these changes

@datelier datelier Awaiting requested review from datelier datelier was automatically assigned from vdaas/maintainer

Assignees
No one assigned
Labels
area/makefile priority/medium size/S type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kmrmt @vdaas-ci @kpango @hlts2