Refactor rotateIfNeeded function to use label selector for listing de…

…ployments
vdaas · Mar 8, 2024 · 6ace761 · 6ace761
1 parent 2b035ee
commit 6ace761
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/pkg/index/operator/service/operator.go b/pkg/index/operator/service/operator.go
@@ -181,8 +181,15 @@ func (o *operator) rotateIfNeeded(ctx context.Context, pod pod.Pod) error {
 	}
 
 	var depList client.DeploymentList
-	label := client.MatchingLabels(map[string]string{o.readReplicaLabelKey: podIdx})
-	if err := o.client.List(ctx, &depList, label); err != nil {
+	selector, err := o.client.LabelSelector(o.readReplicaLabelKey, client.SelectionOpEquals, []string{podIdx})
+	if err != nil {
+		return fmt.Errorf("creating label selector: %w", err)
+	}
+	listOpts := client.ListOptions{
+		Namespace: o.namespace,
+		LabelSelector: selector,
+	}
+	if err := o.client.List(ctx, &depList, &listOpts); err != nil {
 		return err
 	}
 	if len(depList.Items) == 0 {