Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design base trait for ANN algorithms #2344

Closed
wants to merge 12 commits into from

Conversation

kmrmt
Copy link
Contributor

@kmrmt kmrmt commented Feb 13, 2024

Description

I designed base trait for Rust agent to implement ANN algorithms.
I have 2 ideas about query and I do not have idea which one to choose.

Related Issue

Versions

  • Go Version: 1.22.0
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.29.1
  • NGT Version: 2.1.6

Checklist

Special notes for your reviewer

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

Copy link

cloudflare-workers-and-pages bot commented Feb 13, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f395ae7
Status: ✅  Deploy successful!
Preview URL: https://ea7ce480.vald.pages.dev
Branch Preview URL: https://feature-agent-design-algorit.vald.pages.dev

View logs

Signed-off-by: Kosuke Morimoto <[email protected]>
Signed-off-by: Kosuke Morimoto <[email protected]>
Signed-off-by: Kosuke Morimoto <[email protected]>
Signed-off-by: Kosuke Morimoto <[email protected]>
Signed-off-by: Kosuke Morimoto <[email protected]>
Signed-off-by: Kosuke Morimoto <[email protected]>
Signed-off-by: Kosuke Morimoto <[email protected]>
@kmrmt kmrmt force-pushed the feature/agent/design-algorithm-base branch from 45d9d2c to 1449608 Compare February 20, 2024 06:59
Signed-off-by: Kosuke Morimoto <[email protected]>
Signed-off-by: Kosuke Morimoto <[email protected]>
@github-actions github-actions bot added size/XL and removed size/M labels Feb 21, 2024
@kmrmt kmrmt changed the title [WIP] design base trait for ANN algorithms design base trait for ANN algorithms Feb 21, 2024
@kmrmt kmrmt marked this pull request as ready for review February 21, 2024 11:43
Copy link
Contributor

@ykadowak ykadowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To design the base trait correctly, I think it's necessary to try implementing a simple gRPC server that uses it. For me It's difficult to decide which is better just based on the current implementation.

If others have opinions, I will go along with them.

Signed-off-by: Kosuke Morimoto <[email protected]>
@kmrmt kmrmt force-pushed the feature/agent/design-algorithm-base branch from 42c6dde to 42175a2 Compare March 7, 2024 08:36
Signed-off-by: Kosuke Morimoto <[email protected]>
Signed-off-by: Kosuke Morimoto <[email protected]>
@kmrmt kmrmt closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants