Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new grafana dashboard for agent memory metrics #2279

Merged
merged 3 commits into from
Dec 27, 2023

Conversation

kmrmt
Copy link
Contributor

@kmrmt kmrmt commented Dec 21, 2023

Description:

This PR includes the visualization for the metrics about agent memory implemented by #2161 and tiny bug fix for the metrics.

Related Issue:

Versions:

  • Go Version: 1.21.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.4
  • NGT Version: 2.1.6

Checklist:

Special notes for your reviewer:

Signed-off-by: Kosuke Morimoto <[email protected]>
Signed-off-by: Kosuke Morimoto <[email protected]>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (78bd472) 29.99% compared to head (7d40ddf) 29.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2279      +/-   ##
==========================================
- Coverage   29.99%   29.97%   -0.02%     
==========================================
  Files         371      371              
  Lines       36126    36126              
==========================================
- Hits        10836    10829       -7     
- Misses      24778    24782       +4     
- Partials      512      515       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmrmt kmrmt marked this pull request as ready for review December 21, 2023 08:45
@kmrmt kmrmt requested review from a team, kpango and ykadowak and removed request for a team December 21, 2023 08:45
@kmrmt kmrmt changed the title [WIP] Add new grafana dashboard for agent memory metrics Add new grafana dashboard for agent memory metrics Dec 21, 2023
@kmrmt kmrmt requested review from vankichi and hlts2 December 25, 2023 05:07
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

cloudflare-workers-and-pages bot commented Dec 27, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7d40ddf
Status: ✅  Deploy successful!
Preview URL: https://8162afc2.vald.pages.dev
Branch Preview URL: https://feature-observability-grafan.vald.pages.dev

View logs

@hlts2 hlts2 mentioned this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants