implement malloc metrics #2161

kmrmt · 2023-08-29T02:51:37Z

Description:

internal/observability/metrics/mem package has implementation of metrics
malloc_info metrics needs CGO_ENABLED=1, so I passed the implementation this time

Related Issue:

NONE

Versions:

Go Version: 1.20.5
Docker Version: 24.0.5
Kubernetes Version: v1.27.4
NGT Version: 2.0.16

Checklist:

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer:

vdaas-ci · 2023-08-29T02:51:54Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

github-actions · 2023-08-29T02:59:15Z

internal/core/malloc/malloc_test.go

+		return nil
+	}
+	tests := []test{
+		// TODO test cases


🚫 [golangci] _{reported by reviewdog 🐶}
internal/core/malloc/malloc_test.go:37: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)

github-actions · 2023-08-29T02:59:15Z

internal/observability/metrics/mem/malloc/malloc.go

+	}, nil
+}
+
+func (mm *mallocMetrics) Register(m metrics.Meter) error {


🚫 [golangci] _{reported by reviewdog 🐶}
ST1016: methods on the same type should have the same receiver name (seen 1x "m", 1x "mm") (stylecheck)

codecov · 2023-08-29T03:11:21Z

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9b6217b) 29.80% compared to head (8a7545d) 30.03%.

Files	Patch %	Lines
internal/observability/observability.go	0.00%	1 Missing ⚠️
pkg/agent/core/ngt/usecase/agentd.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2161      +/-   ##
==========================================
+ Coverage   29.80%   30.03%   +0.23%     
==========================================
  Files         372      371       -1     
  Lines       36372    36089     -283     
==========================================
- Hits        10840    10839       -1     
+ Misses      25019    24737     -282     
  Partials      513      513

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cloudflare-workers-and-pages · 2023-08-29T04:08:45Z

Deploying with Cloudflare Pages

Latest commit:	`8a7545d`
Status:	✅ Deploy successful!
Preview URL:	https://cb44077a.vald.pages.dev
Branch Preview URL:	https://feature-metrics-malloc-info.vald.pages.dev

View logs

This commit fixes the style issues introduced in d9e1940 according to the output from Gofumpt and Prettier. Details: #2161

This commit fixes the style issues introduced in 94ff86c according to the output from Gofumpt and Prettier. Details: #2161

github-actions · 2023-12-12T07:09:14Z

internal/observability/metrics/mem/index/index.go

-			numGC.Observe(ctx, int64(mstats.NextGC))
+			numGC.Observe(ctx, int64(mstats.NumGC))
+			numForcedGC.Observe(ctx, int64(mstats.NumForcedGC))
+


🚫 [golangci] _{reported by reviewdog 🐶}
File is not gofumpt-ed (gofumpt)

github-actions · 2023-12-12T07:09:14Z

internal/observability/metrics/mem/index/index.go

+	numForcedGCMetricsDescription = "The number of GC cycles called by the application"
+
+	heapWillReturnMetricsName        = "heap_will_return_bytes"
+	heapWillReturnMetricsDescription = "Bytes of returning to OS. It contains the two following parts (heapWillReturn = heapIdle - heapReleased)"


🚫 [golangci] _{reported by reviewdog 🐶}
G101: Potential hardcoded credentials (gosec)

github-actions · 2023-12-12T07:09:15Z

internal/observability/metrics/mem/proc/status.go

+				case strings.HasPrefix(line, "VmPeak"):
+					f, err := strconv.ParseInt(fields[1], 10, 64)
+					if err == nil {
+						vmpeak.Observe(ctx, f*1024)


🚫 [golangci] _{reported by reviewdog 🐶}
mnd: Magic number: 1024, in detected (gomnd)

github-actions · 2023-12-12T07:09:15Z

internal/observability/metrics/mem/proc/status.go

+				case strings.HasPrefix(line, "VmSize"):
+					f, err := strconv.ParseInt(fields[1], 10, 64)
+					if err == nil {
+						vmsize.Observe(ctx, f*1024)


🚫 [golangci] _{reported by reviewdog 🐶}
mnd: Magic number: 1024, in detected (gomnd)

github-actions · 2023-12-12T07:09:15Z

internal/observability/metrics/mem/proc/status.go

+				case strings.HasPrefix(line, "VmHWM"):
+					f, err := strconv.ParseInt(fields[1], 10, 64)
+					if err == nil {
+						vmhwm.Observe(ctx, f*1024)


🚫 [golangci] _{reported by reviewdog 🐶}
mnd: Magic number: 1024, in detected (gomnd)

github-actions · 2023-12-12T07:09:15Z

internal/observability/metrics/mem/index/index.go

@@ -246,6 +415,12 @@
 		return err
 	}

+	looksup, err := m.AsyncInt64().Gauge(


🚫 [golangci] _{reported by reviewdog 🐶}
ineffectual assignment to err (ineffassign)

github-actions · 2023-12-12T07:09:15Z

internal/observability/metrics/mem/proc/status.go

+	}, nil
+}
+
+func (p *procStatusMetrics) Register(m metrics.Meter) error {


🚫 [golangci] _{reported by reviewdog 🐶}
Function name: Register, Cyclomatic Complexity: 39, Halstead Volume: 4841.03, Maintainability Index: 18 (maintidx)

github-actions · 2023-12-12T07:10:10Z

internal/observability/metrics/mem/proc/status.go

+				case strings.HasPrefix(line, "VmPeak"):
+					f, err := strconv.ParseInt(fields[1], 10, 64)
+					if err == nil {
+						vmpeak.Observe(ctx, f*1024)


🚫 [golangci] _{reported by reviewdog 🐶}
mnd: Magic number: 1024, in detected (gomnd)

github-actions · 2023-12-12T07:10:10Z

internal/observability/metrics/mem/proc/status.go

+				case strings.HasPrefix(line, "VmSize"):
+					f, err := strconv.ParseInt(fields[1], 10, 64)
+					if err == nil {
+						vmsize.Observe(ctx, f*1024)


🚫 [golangci] _{reported by reviewdog 🐶}
mnd: Magic number: 1024, in detected (gomnd)

github-actions · 2023-12-12T07:10:10Z

internal/observability/metrics/mem/proc/status.go

+				case strings.HasPrefix(line, "VmHWM"):
+					f, err := strconv.ParseInt(fields[1], 10, 64)
+					if err == nil {
+						vmhwm.Observe(ctx, f*1024)


🚫 [golangci] _{reported by reviewdog 🐶}
mnd: Magic number: 1024, in detected (gomnd)

github-actions · 2023-12-12T07:10:10Z

internal/observability/metrics/mem/proc/status.go

+	}, nil
+}
+
+func (p *procStatusMetrics) Register(m metrics.Meter) error {


🚫 [golangci] _{reported by reviewdog 🐶}
Function name: Register, Cyclomatic Complexity: 39, Halstead Volume: 4841.03, Maintainability Index: 18 (maintidx)

This commit fixes the style issues introduced in 94ff86c according to the output from Gofumpt and Prettier. Details: #2161

Signed-off-by: Kosuke Morimoto <[email protected]>

This commit fixes the style issues introduced in 6dfa2c8 according to the output from Gofumpt and Prettier. Details: #2161

Signed-off-by: Kosuke Morimoto <[email protected]>

This commit fixes the style issues introduced in 8c29a17 according to the output from Gofumpt and Prettier. Details: #2161

Signed-off-by: Kosuke Morimoto <[email protected]>

This commit fixes the style issues introduced in c6e1311 according to the output from Gofumpt and Prettier. Details: #2161

Signed-off-by: Kosuke Morimoto <[email protected]>

This commit fixes the style issues introduced in c8b302e according to the output from Gofumpt and Prettier. Details: #2161

Signed-off-by: Kosuke Morimoto <[email protected]>

hlts2

LGTM!!

github-actions bot added team/set SET team area/internal area/agent/core size/XL type/feature New feature priority/medium labels Aug 29, 2023

github-actions bot reviewed Aug 29, 2023

View reviewed changes

kmrmt force-pushed the feature/metrics/malloc_info branch from 7c60cb8 to f77d5e4 Compare August 29, 2023 04:13

kmrmt marked this pull request as ready for review August 29, 2023 10:34

kmrmt changed the title ~~[WIP] implement malloc metrics~~ implement malloc metrics Aug 29, 2023

kmrmt force-pushed the feature/metrics/malloc_info branch 3 times, most recently from 40bf9ac to 5984b75 Compare September 7, 2023 01:04

kmrmt force-pushed the feature/metrics/malloc_info branch 2 times, most recently from 4326104 to 7a751e6 Compare September 11, 2023 05:22

deepsource-autofix bot added a commit that referenced this pull request Dec 12, 2023

style: format code with Gofumpt and Prettier

3ad5912

This commit fixes the style issues introduced in d9e1940 according to the output from Gofumpt and Prettier. Details: #2161

kmrmt force-pushed the feature/metrics/malloc_info branch from 3ad5912 to 94ff86c Compare December 12, 2023 07:05

github-actions bot added the size/XXL label Dec 12, 2023

deepsource-autofix bot added a commit that referenced this pull request Dec 12, 2023

style: format code with Gofumpt and Prettier

1af6cee

This commit fixes the style issues introduced in 94ff86c according to the output from Gofumpt and Prettier. Details: #2161

github-actions bot removed the size/XL label Dec 12, 2023

github-actions bot reviewed Dec 12, 2023

View reviewed changes

kmrmt requested review from a team, kpango and ykadowak and removed request for a team December 12, 2023 08:32

kmrmt pushed a commit that referenced this pull request Dec 12, 2023

style: format code with Gofumpt and Prettier

066c2a0

This commit fixes the style issues introduced in 94ff86c according to the output from Gofumpt and Prettier. Details: #2161

kmrmt and others added 16 commits December 18, 2023 12:07

make format

9c23b1d

Signed-off-by: Kosuke Morimoto <[email protected]>

style: format code with Gofumpt and Prettier

99264b7

This commit fixes the style issues introduced in 6dfa2c8 according to the output from Gofumpt and Prettier. Details: #2161

make format

b43171b

Signed-off-by: Kosuke Morimoto <[email protected]>

fix

145be2a

Signed-off-by: Kosuke Morimoto <[email protected]>

fix

0d709fd

Signed-off-by: Kosuke Morimoto <[email protected]>

fix

b507ef2

Signed-off-by: Kosuke Morimoto <[email protected]>

make format

b8e65b0

Signed-off-by: Kosuke Morimoto <[email protected]>

style: format code with Gofumpt and Prettier

5725b6f

This commit fixes the style issues introduced in 8c29a17 according to the output from Gofumpt and Prettier. Details: #2161

fix

350c89b

Signed-off-by: Kosuke Morimoto <[email protected]>

make format

0932cc3

Signed-off-by: Kosuke Morimoto <[email protected]>

remove malloc_info

2562881

Signed-off-by: Kosuke Morimoto <[email protected]>

remove unused error

60ebb81

Signed-off-by: Kosuke Morimoto <[email protected]>

make format

eca39ad

Signed-off-by: Kosuke Morimoto <[email protected]>

style: format code with Gofumpt and Prettier

b6a33a2

This commit fixes the style issues introduced in c6e1311 according to the output from Gofumpt and Prettier. Details: #2161

type assertion check

f401d82

Signed-off-by: Kosuke Morimoto <[email protected]>

style: format code with Gofumpt and Prettier

7b2460b

This commit fixes the style issues introduced in c8b302e according to the output from Gofumpt and Prettier. Details: #2161

kmrmt force-pushed the feature/metrics/malloc_info branch from bf35601 to 7b2460b Compare December 18, 2023 03:07

skipcq: GO-R1005

8a7545d

Signed-off-by: Kosuke Morimoto <[email protected]>

kmrmt requested review from a team, vankichi and hlts2 and removed request for kpango, ykadowak and a team December 18, 2023 05:26

vankichi approved these changes Dec 18, 2023

View reviewed changes

hlts2 approved these changes Dec 18, 2023

View reviewed changes

hlts2 merged commit ceb04ea into main Dec 18, 2023
97 of 99 checks passed

hlts2 deleted the feature/metrics/malloc_info branch December 18, 2023 07:34

vankichi mentioned this pull request Dec 19, 2023

[patch] release v1.7.10 #2275

Merged

kmrmt mentioned this pull request Dec 21, 2023

Add new grafana dashboard for agent memory metrics #2279

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implement malloc metrics #2161

implement malloc metrics #2161

kmrmt commented Aug 29, 2023 •

edited

Loading

vdaas-ci commented Aug 29, 2023

github-actions bot Aug 29, 2023

github-actions bot Aug 29, 2023

codecov bot commented Aug 29, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Aug 29, 2023 •

edited

Loading

github-actions bot Dec 12, 2023

github-actions bot Dec 12, 2023

github-actions bot Dec 12, 2023

github-actions bot Dec 12, 2023

github-actions bot Dec 12, 2023

github-actions bot Dec 12, 2023

github-actions bot Dec 12, 2023

github-actions bot Dec 12, 2023

github-actions bot Dec 12, 2023

github-actions bot Dec 12, 2023

github-actions bot Dec 12, 2023

hlts2 left a comment

implement malloc metrics #2161

implement malloc metrics #2161

Conversation

kmrmt commented Aug 29, 2023 • edited Loading

Description:

Related Issue:

Versions:

Checklist:

Special notes for your reviewer:

vdaas-ci commented Aug 29, 2023

github-actions bot Aug 29, 2023

Choose a reason for hiding this comment

github-actions bot Aug 29, 2023

Choose a reason for hiding this comment

codecov bot commented Aug 29, 2023 • edited Loading

Codecov Report

cloudflare-workers-and-pages bot commented Aug 29, 2023 • edited Loading

Deploying with Cloudflare Pages

github-actions bot Dec 12, 2023

Choose a reason for hiding this comment

github-actions bot Dec 12, 2023

Choose a reason for hiding this comment

github-actions bot Dec 12, 2023

Choose a reason for hiding this comment

github-actions bot Dec 12, 2023

Choose a reason for hiding this comment

github-actions bot Dec 12, 2023

Choose a reason for hiding this comment

github-actions bot Dec 12, 2023

Choose a reason for hiding this comment

github-actions bot Dec 12, 2023

Choose a reason for hiding this comment

github-actions bot Dec 12, 2023

Choose a reason for hiding this comment

github-actions bot Dec 12, 2023

Choose a reason for hiding this comment

github-actions bot Dec 12, 2023

Choose a reason for hiding this comment

github-actions bot Dec 12, 2023

Choose a reason for hiding this comment

hlts2 left a comment

Choose a reason for hiding this comment

kmrmt commented Aug 29, 2023 •

edited

Loading

codecov bot commented Aug 29, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Aug 29, 2023 •

edited

Loading