Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change discoverer client to broadcast to read replicas #2276

Merged
merged 14 commits into from
Jan 19, 2024

Merge branch 'main' into feature/readreplica/client

115d09a
Select commit
Loading
Failed to load commit list.
Merged

Change discoverer client to broadcast to read replicas #2276

Merge branch 'main' into feature/readreplica/client
115d09a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 19, 2024 in 1s

30.13% (+0.02%) compared to 306f0ef

View this Pull Request on Codecov

30.13% (+0.02%) compared to 306f0ef

Details

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (306f0ef) 30.11% compared to head (115d09a) 30.13%.

Files Patch % Lines
internal/config/lb.go 0.00% 13 Missing ⚠️
internal/client/v1/client/discoverer/option.go 0.00% 10 Missing ⚠️
internal/client/v1/client/discoverer/discover.go 68.18% 7 Missing ⚠️
pkg/gateway/lb/service/gateway.go 0.00% 7 Missing ⚠️
pkg/gateway/lb/handler/grpc/handler.go 0.00% 6 Missing ⚠️
pkg/gateway/lb/usecase/vald.go 85.71% 3 Missing and 1 partial ⚠️
pkg/gateway/lb/handler/grpc/aggregation.go 0.00% 1 Missing ⚠️
...kg/index/job/readreplica/rotate/service/rotator.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2276      +/-   ##
==========================================
+ Coverage   30.11%   30.13%   +0.02%     
==========================================
  Files         389      389              
  Lines       40757    40826      +69     
==========================================
+ Hits        12272    12303      +31     
- Misses      27833    27871      +38     
  Partials      652      652

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov