Change discoverer client to broadcast to read replicas #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team/set
|
[WARNING:INTCFG] Changes in |
|
[CHATOPS:HELP] ChatOps commands.
|
Deploying with
|
| Latest commit: |
115d09a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a49e96b9.vald.pages.dev |
| Branch Preview URL: | https://feature-readreplica-client.vald.pages.dev |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2276 +/- ##
==========================================
+ Coverage 30.11% 30.13% +0.02%
==========================================
Files 389 389
Lines 40757 40826 +69
==========================================
+ Hits 12272 12303 +31
- Misses 27833 27871 +38
Partials 652 652 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
size/L
and removed
team/set
ykadowak
force-pushed
the
feature/readreplica/client
branch
from
3d16cba to
8b44187
Compare
github-actions
bot
added
team/set
ykadowak
force-pushed
the
feature/readreplica/client
branch
2 times, most recently
from
bf3d7a6 to
43aaad1
Compare
ykadowak
force-pushed
the
feature/readreplica/client
branch
from
43aaad1 to
a362b8a
Compare
ykadowak
requested review from
a team,
vankichi and
hlts2
and removed request for
a team
vankichi
approved these changes
Jan 19, 2024
This was referenced Jan 28, 2024
This was referenced Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements
read_replica_clientconfigurationGetReadReplica()round robins across primary client and read replica clients.Will add E2E tests in another PR.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: