Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read replica rotator #2241

Merged
merged 32 commits into from
Nov 29, 2023

Fix camel case

0d57414
Select commit
Loading
Failed to load commit list.
Merged

Add read replica rotator #2241

Fix camel case
0d57414
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 28, 2023 in 0s

30.49% (-0.21%) compared to dcf2064

View this Pull Request on Codecov

30.49% (-0.21%) compared to dcf2064

Details

Codecov Report

Attention: 268 lines in your changes are missing coverage. Please review.

Comparison is base (dcf2064) 30.70% compared to head (0d57414) 30.49%.
Report is 2 commits behind head on main.

Files Patch % Lines
...kg/index/job/readreplica/rotate/service/rotator.go 4.31% 222 Missing ⚠️
pkg/index/job/readreplica/rotate/config/config.go 0.00% 27 Missing ⚠️
...kg/index/job/readreplica/rotate/service/options.go 20.00% 9 Missing and 3 partials ⚠️
internal/config/readreplica_rotate.go 0.00% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2241      +/-   ##
==========================================
- Coverage   30.70%   30.49%   -0.21%     
==========================================
  Files         358      362       +4     
  Lines       35095    35376     +281     
==========================================
+ Hits        10775    10788      +13     
- Misses      23813    24076     +263     
- Partials      507      512       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov