Fix e2e-max-dim test #2028
Merged
Fix e2e-max-dim test #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[CHATOPS:HELP] ChatOps commands.
|
ykadowak
added
actions/e2e-deploy
and removed
team/sre
ykadowak
force-pushed
the
ci/helm/fix-max-dimensions
branch
from
1083f2c to
fe65219
Compare
Deploying with
|
| Latest commit: |
4852790
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://13ed5b89.vald.pages.dev |
| Branch Preview URL: | https://ci-helm-fix-max-dimensions.vald.pages.dev |
kpango
reviewed
May 16, 2023
| @@ -125,9 +125,7 @@ runs: | |||
| echo "POD_NAME=${podname}" >> $GITHUB_OUTPUT | |||
| env: | |||
| VALUES: ${{ inputs.values }} | |||
| # TODO: currently, we can't pass helm options to the make command. | |||
| # Is it really necessary in the first place? | |||
| # HELM_EXTRA_OPTIONS: ${{ inputs.helm_extra_options }} | |||
There was a problem hiding this comment.
The "make k8s/vald/deploy" command is useful for building a Vald Cluster using the "Local Chart".
However, since the internal settings can only be changed statically by modifying values.yaml, I think it would be useful for CI if dynamic settings such as the number of vector dimensions could be changed on the command line.
For this reason, I believe the HELM_EXTRA_OPTS will be a very useful feature when using Local Charts in CI.
ykadowak
added
actions/e2e-deploy
actions/e2e-chaos
actions/e2e-profiling
actions/e2e-max-dim
and removed
actions/e2e-max-dim
labels
Profile Report
|
ykadowak
commented
May 17, 2023
| @@ -150,3 +150,86 @@ jobs: | |||
| env: | |||
| GITHUB_USER: ${{ secrets.DISPATCH_USER }} | |||
| GITHUB_TOKEN: ${{ secrets.DISPATCH_TOKEN }} | |||
| crud-on-remote-helm-chart: | |||
There was a problem hiding this comment.
This should be tested on the next release.
ykadowak
requested review from
kpango,
a team and
vankichi
and removed request for
a team
vankichi
approved these changes
May 17, 2023
This was referenced Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is another fix for the regression that introduced here #2024 following #2025. In addition, changed the default to use local charts, and testing of remote charts are performed after release.
More specifically this PR made the following changes:
e2e-max-dimevery time it changes the dimension.use_local_charts: trueas defaultRelated Issue:
Versions:
Checklist:
Special notes for your reviewer: