Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
sagemathgh-37821: Fix category of ModularFormsRing and documentation …
…cleanup <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The goal of this PR is twofold: First, we fix the category of modular forms ring as per PR sagemath#37797 to make the following code work: ``` sage: M = ModularFormsRing(1) sage: M['z', 'w'] Multivariate Polynomial Ring in z, w over Ring of Modular Forms for Modular Group SL(2,Z) over Rational Field ``` Second, we do a documentation and PEP8 cleanup of the class `ModularFormsRing`. CC: @fchapoton ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37821 Reported by: David Ayotte Reviewer(s): Kwankyu Lee
- Loading branch information