Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace ElSelect with ElSelectV2 in component adapter for better performance #5085

Merged
merged 6 commits into from
Dec 11, 2024
Merged

feat: replace ElSelect with ElSelectV2 in component adapter for better performance #5085

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
29692f5
Merge branch 'main' of https://github.com/ArthurDarkstone/vue-vben-admin
ArthurDarkstone Nov 5, 2024
4f239ab
Merge branch 'main' of https://github.com/ArthurDarkstone/vue-vben-admin
ArthurDarkstone Nov 7, 2024
01b60f0
Merge branch 'main' of https://github.com/ArthurDarkstone/vue-vben-admin
ArthurDarkstone Dec 9, 2024
657288d
Merge branch 'vbenjs:main' into main
ArthurDarkstone Dec 9, 2024
02904e2
Merge branch 'main' of https://github.com/ArthurDarkstone/vue-vben-admin
ArthurDarkstone Dec 9, 2024
645a7a4
feat: replace `ElSelect` with `ElSelectV2` in component adapter for b…
ArthurDarkstone Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions apps/web-ele/src/adapter/component/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,9 @@ import {
ElInput,
ElInputNumber,
ElNotification,
ElOption,
ElRadio,
ElRadioButton,
ElRadioGroup,
ElSelect,
ElSelectV2,
ElSpace,
ElSwitch,
Expand Down Expand Up @@ -165,21 +163,7 @@ async function initComponentAdapter() {
);
},
Select: (props, { attrs, slots }) => {
let defaultSlot;
if (Reflect.has(slots, 'default')) {
defaultSlot = slots.default;
} else {
const { options } = attrs;
if (Array.isArray(options)) {
defaultSlot = () => options.map((option) => h(ElOption, option));
}
}
const placeholder = props?.placeholder || $t(`ui.placeholder.select`);
return h(
ElSelect,
{ ...props, ...attrs, placeholder },
{ ...slots, default: defaultSlot },
);
return h(ElSelectV2, { ...props, attrs }, slots);
},
Space: ElSpace,
Switch: ElSwitch,
Expand Down
Loading