feat: replace ElSelect with ElSelectV2 in component adapter for better performance

[ArthurDarkstone]

Description

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

• If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
• Run the tests with pnpm test.
• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• New Features

  • Introduced ElSelectV2 component in the Select function for improved functionality.

• Bug Fixes

  • Removed unused ElOption component, streamlining the component usage.

• Documentation

  • Updated comments for better clarity on component purposes and usage.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 645a7a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/web-ele/src/adapter/component/index.ts

Oops! Something went wrong! :(

ESLint: 9.16.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/node_modules/@vben/eslint-config/dist/index.mjs' imported from /eslint.config.mjs
at finalizeResolution (node:internal/modules/esm/resolve:257:11)
at moduleResolve (node:internal/modules/esm/resolve:914:10)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

Walkthrough

The changes involve modifications to the index.ts file in the apps/web-ele/src/adapter/component directory. The Select function has been updated to utilize the ElSelectV2 component instead of the previous ElSelect, with the removal of logic related to default slots and options. Additionally, the import of ElOption has been eliminated, indicating its removal from the codebase. The overall structure and component registration remain unchanged, with some comments reorganized for clarity.

Changes

File Path	Change Summary
apps/web-ele/src/adapter/component/index.ts	- Replaced ElSelect with ElSelectV2 in Select function. - Removed ElOption import. - Simplified rendering logic for Select. - Reorganized comments for clarity.

Poem

🐇 In the meadow where we play,
New components come to stay.
ElSelectV2 hops in bright,
While ElOption takes its flight.
With clearer paths and joyful cheer,
Our code's a garden, blooming here! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 018ddc7 and 645a7a4.

📒 Files selected for processing (1)

• apps/web-ele/src/adapter/component/index.ts (1 hunks)

🔇 Additional comments (3)

apps/web-ele/src/adapter/component/index.ts (3)

Line range hint 39-53: LGTM: Consistent use of ElSelectV2 across adapter

The ApiSelect component is already configured to use ElSelectV2, showing good architectural consistency with this change. The adapter pattern is properly maintained, keeping the component abstraction intact.

---

166-166: Verify that ElSelectV2 supports all required features

While the implementation is more concise, ElSelectV2 handles features differently from ElSelect. Please ensure:

• Remote search functionality still works
• Custom option rendering is supported
• Keyboard navigation behaves as expected

Consider documenting the key differences between ElSelect and ElSelectV2 in the component adapter documentation to help other developers understand the implications of this change.

✅ Verification successful

Based on the search results, I can now generate the final response:

ElSelectV2 implementation appears to be a safe replacement

The codebase analysis shows that:

• The Select component is used consistently through the component adapter pattern
• Both ApiSelect and regular Select implementations properly forward all props, attrs, and slots
• No specific ElSelect-only features are being used across the codebase
• The implementation maintains the same interface contract by passing through all props and slots

Since ElSelectV2 is Element Plus's recommended virtual scrolling select component and the adapter maintains the same props/slots forwarding pattern, this change appears to be a safe improvement.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for custom Select implementations that might rely on ElSelect-specific features
rg -l "ElSelect" --type ts

Length of output: 70

---

Script:

#!/bin/bash
# Let's check the actual implementation and usage patterns
rg "ElSelect" -A 5 -B 5 --type ts

Length of output: 2247

---

Script:

#!/bin/bash
# Search for any Select component usage patterns in the codebase
rg -A 3 -B 3 "Select.*props" --type ts

Length of output: 5042

---

Script:

#!/bin/bash
# Look for any remote search, keyboard navigation, or custom rendering patterns
rg "remote|filterable|keyboard|renderLabel|renderOption" --type ts

Length of output: 499

---

Script:

#!/bin/bash
# Check if there are any test files that might reveal expected behavior
fd "test|spec" -e ts -e tsx -X rg "Select"

Length of output: 185

---

166-166: Document performance improvements

While ElSelectV2 is known for better performance with large datasets due to virtual scrolling, it would be valuable to:

1. Document the performance improvements observed
2. Specify the dataset sizes where this change makes a significant impact

Consider adding a comment in the code documenting the performance considerations that led to choosing ElSelectV2.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.