fix: form does not take effect in vertical layout

[anncwb]

Description

fixed #4675

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

• If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
• Run the tests with pnpm test.
• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• New Features

  • Enhanced functionality of the form field component for improved event handling and style application.

• Bug Fixes

  • Refined logic for binding event objects, ensuring better compatibility across component types.

• Documentation

  • Improved clarity and efficiency in the component's rendering logic, particularly regarding props and events management.

[changeset-bot]

⚠️ No Changeset found

Latest commit: bfe3ab9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The changes in the form-field.vue file focus on enhancing the functionality and control flow of the form field component. The FormLabel component's class binding has been updated to ensure consistent application of the labelClass. Additionally, the fieldBindEvent function has been refined for better event handling. The computed properties remain but are optimized for correct prop passing to dynamically rendered components. Overall, these updates aim to improve the component's rendering logic and event management.

Changes

File Path	Change Summary
packages/@core/ui-kit/form-ui/src/form-render/form-field.vue	Updated template and script sections; modified FormLabel class binding; refined fieldBindEvent for better event handling; optimized computed properties for prop passing.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure labelClass is always applied when layout is vertical (#4675)	✅

Possibly related issues

• Bug: Form的layout值为vertical时，表单的必填星号位置错误 #4661: The changes may address the issue of the required asterisk position in vertical layouts, as they involve updates to the FormLabel component.

Possibly related PRs

• fix: fixed the form component componentProps using the function that did not meet expectations #4426: This PR modifies the form-field.vue file, enhancing the Props interface and computed properties, which relates to the changes made in the main PR that also focuses on the form-field.vue file's functionality and event handling.
• fix: form required style adjustment #4668: This PR also addresses changes in the form-field.vue file, specifically focusing on the layout and class binding of the FormLabel component, which aligns with the main PR's updates to the FormLabel class binding and event handling logic.

Suggested reviewers

• vince292007

🐰 In the meadow, where forms do play,
A label's class now finds its way.
Events are bound with care and grace,
In vertical layouts, they find their place.
Hooray for changes, let’s hop and cheer,
For clearer forms that bring us near! 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 240f0b5 and bfe3ab9.

📒 Files selected for processing (1)

• packages/@core/ui-kit/form-ui/src/form-render/form-field.vue (1 hunks)

🧰 Additional context used

🔇 Additional comments (2)

packages/@core/ui-kit/form-ui/src/form-render/form-field.vue (2)

284-284: LGTM: Fix for labelClass application

This change correctly addresses the issue described in PR #4680 and the linked issue #4675. By moving labelClass outside of the conditional object in the :class binding, it ensures that the custom label class is always applied, regardless of the form's layout (vertical or horizontal).

This fix resolves the bug where the labelClass parameter was not taking effect when the form's layout was set to vertical, without introducing any new complexity or potential side effects.

---

Line range hint 1-368: Summary: Effective bug fix with minimal changes

The change in this file is focused and addresses the specific issue reported in PR #4680 and issue #4675. The modification to the FormLabel component's class binding ensures that the labelClass is consistently applied, resolving the bug where it wasn't taking effect in the vertical layout.

The rest of the file remains unchanged, which is appropriate for this targeted bug fix. The implementation is clean and doesn't introduce any new complexity or potential side effects.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.