Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed some style issues #4379

Merged
merged 1 commit into from
Sep 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apps/web-antd/src/router/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@ const router = createRouter({
: createWebHistory(import.meta.env.VITE_BASE),
// 应该添加到路由的初始路由列表。
routes,
scrollBehavior: () => ({ left: 0, top: 0 }),
scrollBehavior: (to, _from, savedPosition) => {
if (savedPosition) {
return savedPosition;
}
return to.hash ? { behavior: 'smooth', el: to.hash } : { left: 0, top: 0 };
},
// 是否应该禁止尾部斜杠。
// strict: true,
});
Expand Down
7 changes: 6 additions & 1 deletion apps/web-ele/src/router/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@ const router = createRouter({
: createWebHistory(import.meta.env.VITE_BASE),
// 应该添加到路由的初始路由列表。
routes,
scrollBehavior: () => ({ left: 0, top: 0 }),
scrollBehavior: (to, _from, savedPosition) => {
if (savedPosition) {
return savedPosition;
}
return to.hash ? { behavior: 'smooth', el: to.hash } : { left: 0, top: 0 };
},
// 是否应该禁止尾部斜杠。
// strict: true,
});
Expand Down
7 changes: 6 additions & 1 deletion apps/web-naive/src/router/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@ const router = createRouter({
: createWebHistory(import.meta.env.VITE_BASE),
// 应该添加到路由的初始路由列表。
routes,
scrollBehavior: () => ({ left: 0, top: 0 }),
scrollBehavior: (to, _from, savedPosition) => {
if (savedPosition) {
return savedPosition;
}
return to.hash ? { behavior: 'smooth', el: to.hash } : { left: 0, top: 0 };
},
// 是否应该禁止尾部斜杠。
// strict: true,
});
Expand Down
10 changes: 5 additions & 5 deletions docs/src/en/guide/essentials/development.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,15 @@ The execution command is: `pnpm run [script]` or `npm run [script]`.
// Build a local Docker image
"build:docker": "./build-local-docker-image.sh",
// Build the web-antd application separately
"build:antd": "pnpm run build --filter=@vben/web-antd",
"build:antd": "pnpm -F @vben/web-antd run build",
// Build the documentation separately
"build:docs": "pnpm run build --filter=@vben/docs",
"build:docs": "pnpm -F @vben/docs run build",
// Build the web-ele application separately
"build:ele": "pnpm run build --filter=@vben/web-ele",
"build:ele": "pnpm -F @vben/web-ele run build",
// Build the web-naive application separately
"build:naive": "pnpm run build --filter=@vben/naive",
"build:naive": "pnpm -F @vben/web-naive run build",
// Build the playground application separately
"build:play": "pnpm run build --filter=@vben/playground",
"build:play": "pnpm -F @vben/playground run build",
// Changeset version management
"changeset": "pnpm exec changeset",
// Check for various issues in the project
Expand Down
10 changes: 5 additions & 5 deletions docs/src/en/guide/introduction/thin.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,11 @@ After slimming down, you may need to adjust commands according to your project.
```json
{
"scripts": {
"build:antd": "pnpm run build --filter=@vben/web-antd",
"build:docs": "pnpm run build --filter=@vben/docs",
"build:ele": "pnpm run build --filter=@vben/web-ele",
"build:naive": "pnpm run build --filter=@vben/web-naive",
"build:play": "pnpm run build --filter=@vben/playground",
"build:antd": "pnpm -F @vben/web-antd run build",
"build:docs": "pnpm -F @vben/docs run build",
"build:ele": "pnpm -F @vben/web-ele run build",
"build:naive": "pnpm -F @vben/web-naive run build",
"build:play": "pnpm -F @vben/playground run build",
"dev:antd": "pnpm -F @vben/web-antd run dev",
"dev:docs": "pnpm -F @vben/docs run dev",
"dev:ele": "pnpm -F @vben/web-ele run dev",
Expand Down
10 changes: 5 additions & 5 deletions docs/src/guide/essentials/development.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,15 @@ npm 脚本是项目常见的配置,用于执行一些常见的任务,比如
// 构建本地 docker 镜像
"build:docker": "./build-local-docker-image.sh",
// 单独构建 web-antd 应用
"build:antd": "pnpm run build --filter=@vben/web-antd",
"build:antd": "pnpm -F @vben/web-antd run build",
// 单独构建文档
"build:docs": "pnpm run build --filter=@vben/docs",
"build:docs": "pnpm -F @vben/docs run build",
// 单独构建 web-ele 应用
"build:ele": "pnpm run build --filter=@vben/web-ele",
"build:ele": "pnpm -F @vben/web-ele run build",
// 单独构建 web-naive 应用
"build:naive": "pnpm run build --filter=@vben/naive",
"build:naive": "pnpm -F @vben/web-naive run build",
// 单独构建 playground 应用
"build:play": "pnpm run build --filter=@vben/playground",
"build:play": "pnpm -F @vben/playground run build",
// changeset 版本管理
"changeset": "pnpm exec changeset",
// 检查项目各种问题
Expand Down
10 changes: 5 additions & 5 deletions docs/src/guide/introduction/thin.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,11 @@ pnpm install
```json
{
"scripts": {
"build:antd": "pnpm run build --filter=@vben/web-antd",
"build:docs": "pnpm run build --filter=@vben/docs",
"build:ele": "pnpm run build --filter=@vben/web-ele",
"build:naive": "pnpm run build --filter=@vben/web-naive",
"build:play": "pnpm run build --filter=@vben/playground",
"build:antd": "pnpm -F @vben/web-antd run build",
"build:docs": "pnpm -F @vben/docs run build",
"build:ele": "pnpm -F @vben/web-ele run build",
"build:naive": "pnpm -F @vben/web-naive run build",
"build:play": "pnpm -F @vben/playground run build",
"dev:antd": "pnpm -F @vben/web-antd run dev",
"dev:docs": "pnpm -F @vben/docs run dev",
"dev:ele": "pnpm -F @vben/web-ele run dev",
Expand Down
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@
"build": "cross-env NODE_OPTIONS=--max-old-space-size=8192 turbo build",
"build:analyze": "turbo build:analyze",
"build:docker": "./build-local-docker-image.sh",
"build:antd": "pnpm run build --filter=@vben/web-antd",
"build:docs": "pnpm run build --filter=@vben/docs",
"build:ele": "pnpm run build --filter=@vben/web-ele",
"build:naive": "pnpm run build --filter=@vben/web-naive",
"build:play": "pnpm run build --filter=@vben/playground",
"build:antd": "pnpm -F @vben/web-antd run build",
"build:docs": "pnpm -F @vben/docs run build",
"build:ele": "pnpm -F @vben/web-ele run build",
"build:naive": "pnpm -F @vben/web-naive run build",
"build:play": "pnpm -F @vben/playground run build",
"changeset": "pnpm exec changeset",
"check": "pnpm run check:circular && pnpm run check:dep && pnpm run check:type && pnpm check:cspell",
"check:circular": "vsh check-circular",
Expand Down
2 changes: 1 addition & 1 deletion packages/@core/base/shared/src/utils/merge.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export { defu as merge } from 'defu';
export { createDefu as createMerge, defu as merge } from 'defu';
20 changes: 17 additions & 3 deletions packages/@core/ui-kit/form-ui/src/form-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,19 @@ import type { FormActions, VbenFormProps } from './types';
import { toRaw } from 'vue';

import { Store } from '@vben-core/shared/store';
import { bindMethods, isFunction, StateHandler } from '@vben-core/shared/utils';
import {
bindMethods,
createMerge,
isFunction,
StateHandler,
} from '@vben-core/shared/utils';

const merge = createMerge((originObj, key, updates) => {
if (Array.isArray(originObj[key]) && Array.isArray(updates)) {
originObj[key] = updates;
return true;
}
});

function getDefaultState(): VbenFormProps {
return {
Expand Down Expand Up @@ -138,9 +150,11 @@ export class FormApi {
| Partial<VbenFormProps>,
) {
if (isFunction(stateOrFn)) {
this.store.setState(stateOrFn as (prev: VbenFormProps) => VbenFormProps);
this.store.setState((prev) => {
return merge(stateOrFn(prev), prev);
});
} else {
this.store.setState((prev) => ({ ...prev, ...stateOrFn }));
this.store.setState((prev) => merge(stateOrFn, prev));
}
}

Expand Down
12 changes: 6 additions & 6 deletions packages/@core/ui-kit/form-ui/src/form-render/expandable.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export function useExpandable(props: FormRenderProps) {
for (let index = 1; index <= rows; index++) {
maxItem += mapping?.[index] ?? 0;
}
return maxItem - 1;
return maxItem - 1 || 1;
});

watch(
Expand Down Expand Up @@ -50,11 +50,11 @@ export function useExpandable(props: FormRenderProps) {
return;
}
// 小屏幕不计算
if (breakpoints.smaller('sm').value) {
// 保持一行
rowMapping.value = { 1: 2 };
return;
}
// if (breakpoints.smaller('sm').value) {
// // 保持一行
// rowMapping.value = { 1: 2 };
// return;
// }

const formItems = [...wrapperRef.value.children];

Expand Down
2 changes: 2 additions & 0 deletions packages/@core/ui-kit/popup-ui/src/drawer/drawer-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,12 @@ export class DrawerApi {
} = options;

const defaultState: DrawerState = {
class: '',
closable: true,
closeOnClickModal: true,
closeOnPressEscape: true,
confirmLoading: false,
contentClass: '',
footer: true,
isOpen: false,
loading: false,
Expand Down
2 changes: 2 additions & 0 deletions packages/@core/ui-kit/popup-ui/src/drawer/drawer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export interface DrawerProps {
* 取消按钮文字
*/
cancelText?: string;
class?: string;
/**
* 是否显示右上角的关闭按钮
* @default true
Expand All @@ -31,6 +32,7 @@ export interface DrawerProps {
* 确定按钮文字
*/
confirmText?: string;
contentClass?: string;
/**
* 弹窗描述
*/
Expand Down
8 changes: 3 additions & 5 deletions packages/@core/ui-kit/popup-ui/src/drawer/drawer.vue
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,10 @@ import {
import { cn } from '@vben-core/shared/utils';

interface Props extends DrawerProps {
class?: string;
contentClass?: string;
drawerApi?: ExtendedDrawerApi;
}

const props = withDefaults(defineProps<Props>(), {
class: '',
contentClass: '',
drawerApi: undefined,
});

Expand All @@ -44,11 +40,13 @@ const state = props.drawerApi?.useStore?.();

const {
cancelText,
class: drawerClass,
closable,
closeOnClickModal,
closeOnPressEscape,
confirmLoading,
confirmText,
contentClass,
description,
footer: showFooter,
loading: showLoading,
Expand Down Expand Up @@ -98,7 +96,7 @@ function pointerDownOutside(e: Event) {
>
<SheetContent
:class="
cn('flex w-[520px] flex-col', props.class, {
cn('flex w-[520px] flex-col', drawerClass, {
'!w-full': isMobile,
})
"
Expand Down
4 changes: 4 additions & 0 deletions packages/@core/ui-kit/popup-ui/src/modal/modal-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,18 @@ export class ModalApi {

const defaultState: ModalState = {
centered: false,
class: '',
closeOnClickModal: true,
closeOnPressEscape: true,
confirmLoading: false,
contentClass: '',
draggable: false,
footer: true,
footerClass: '',
fullscreen: false,
fullscreenButton: true,
header: true,
headerClass: '',
isOpen: false,
loading: false,
modal: true,
Expand Down
4 changes: 4 additions & 0 deletions packages/@core/ui-kit/popup-ui/src/modal/modal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export interface ModalProps {
* @default false
*/
centered?: boolean;
class?: string;
/**
* 是否显示右上角的关闭按钮
* @default true
Expand All @@ -36,6 +37,7 @@ export interface ModalProps {
* 确定按钮文字
*/
confirmText?: string;
contentClass?: string;
/**
* 弹窗描述
*/
Expand All @@ -50,6 +52,7 @@ export interface ModalProps {
* @default true
*/
footer?: boolean;
footerClass?: string;
/**
* 是否全屏
* @default false
Expand All @@ -65,6 +68,7 @@ export interface ModalProps {
* @default true
*/
header?: boolean;
headerClass?: string;
/**
* 弹窗是否显示
* @default false
Expand Down
21 changes: 7 additions & 14 deletions packages/@core/ui-kit/popup-ui/src/modal/modal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,10 @@ import { cn } from '@vben-core/shared/utils';
import { useModalDraggable } from './use-modal-draggable';

interface Props extends ModalProps {
class?: string;
contentClass?: string;
footerClass?: string;
headerClass?: string;
modalApi?: ExtendedModalApi;
}

const props = withDefaults(defineProps<Props>(), {
class: '',
contentClass: '',
footerClass: '',
headerClass: '',
modalApi: undefined,
});

Expand All @@ -55,17 +47,21 @@ const state = props.modalApi?.useStore?.();
const {
cancelText,
centered,
class: modalClass,
closable,
closeOnClickModal,
closeOnPressEscape,
confirmLoading,
confirmText,
contentClass,
description,
draggable,
footer: showFooter,
footerClass,
fullscreen,
fullscreenButton,
header,
headerClass,
loading: showLoading,
modal,
openAutoFocus,
Expand Down Expand Up @@ -161,7 +157,7 @@ function pointerDownOutside(e: Event) {
:class="
cn(
'border-border left-0 right-0 top-[10vh] mx-auto flex max-h-[80%] w-[520px] flex-col border p-0',
props.class,
modalClass,
{
'left-0 top-0 size-full max-h-full !translate-x-0 !translate-y-0':
shouldFullscreen,
Expand All @@ -186,7 +182,7 @@ function pointerDownOutside(e: Event) {
hidden: !header,
'cursor-move select-none': shouldDraggable,
},
props.headerClass,
headerClass,
)
"
>
Expand Down Expand Up @@ -240,10 +236,7 @@ function pointerDownOutside(e: Event) {
v-if="showFooter"
ref="footerRef"
:class="
cn(
'flex-row items-center justify-end border-t p-2',
props.footerClass,
)
cn('flex-row items-center justify-end border-t p-2', footerClass)
"
>
<slot name="prepend-footer"></slot>
Expand Down
1 change: 1 addition & 0 deletions packages/@core/ui-kit/shadcn-ui/src/components/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ export * from './render-content';
export * from './scrollbar';
export * from './segmented';
export * from './select';
export * from './spine-text';
export * from './spinner';
export * from './swap';
export * from './tooltip';
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { default as VbenSpineText } from './spine-text.vue';
Loading