Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed some style issues #4379

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix: fixed some style issues #4379

merged 1 commit into from
Sep 12, 2024

Conversation

anncwb
Copy link
Collaborator

@anncwb anncwb commented Sep 12, 2024

Description

fixed: #4366

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
  • Run the tests with pnpm test.
  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • New Features

    • Enhanced scroll behavior for smoother navigation between routes, restoring scroll positions and supporting hash-based scrolling.
    • Added customizable CSS class properties for modal and drawer components to improve styling flexibility.
    • Introduced a new VbenSpineText component with a unique text effect and animation.
  • Bug Fixes

    • Improved button interactivity by adding visual feedback during loading states across authentication components.
  • Refactor

    • Updated form component configurations for better responsiveness using Tailwind CSS classes.
    • Streamlined prop handling in modal and drawer components by removing unnecessary default values.
  • Documentation

    • Updated build script commands for consistency and improved readability.

@anncwb anncwb requested review from vince292007 and a team as code owners September 12, 2024 13:57
Copy link

changeset-bot bot commented Sep 12, 2024

⚠️ No Changeset found

Latest commit: f4ba5de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Sep 12, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several changes primarily focused on enhancing the scrollBehavior function in router configurations across multiple applications. The updates allow for improved handling of scroll positions when navigating between routes, including restoring previous scroll positions and supporting hash-based scrolling. Additionally, modifications to build scripts streamline command syntax for package management, and various UI components have been adjusted for better customization and responsiveness.

Changes

Files Change Summary
apps/web-antd/src/router/index.ts, apps/web-ele/src/router/index.ts, apps/web-naive/src/router/index.ts, playground/src/router/index.ts Modified scrollBehavior to handle saved positions and hash-based scrolling instead of returning a fixed position.
docs/src/en/guide/essentials/development.md, docs/src/guide/essentials/development.md, docs/src/guide/introduction/thin.md, package.json Updated build scripts to replace --filter with -F for improved command syntax.
packages/@core/base/shared/src/utils/merge.ts Added createMerge as an alias for createDefu, enhancing merging functionality.
packages/@core/ui-kit/form-ui/src/form-api.ts Introduced a new merge function for state updates within the FormApi class, improving state management.
packages/@core/ui-kit/popup-ui/src/drawer/drawer-api.ts, packages/@core/ui-kit/popup-ui/src/modal/modal-api.ts Added new properties (class, contentClass, etc.) to enhance customization options for UI components.
packages/@core/ui-kit/shadcn-ui/src/components/index.ts Added export statement for spine-text component, improving modularity.
packages/effects/common-ui/src/ui/authentication/*.vue Updated <VbenButton> components to include dynamic class binding for loading states, enhancing user feedback.
playground/src/views/examples/form/custom.vue, playground/src/views/examples/form/dynamic.vue Modified form configuration for better responsiveness and state management.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Router
    participant Component

    User->>Router: Navigate to route
    Router->>Component: Check savedPosition
    alt savedPosition exists
        Router->>Component: Restore scroll position
    else hash exists
        Router->>Component: Scroll to hash element
    else
        Router->>Component: Scroll to top
    end
Loading

Assessment against linked issues

Objective Addressed Explanation
Optimize mobile styles for Form components (#4366)
Ensure Form components display correctly (#4366)

Possibly related PRs

Suggested labels

enhancement

Suggested reviewers

  • vince292007
  • anncwb

Poem

🐰 In the meadow where bunnies hop,
Changes sprout, and never stop!
Scrolls now dance with a gentle grace,
Forms adapt, keeping pace.
With every tweak, our joy will grow,
Hooray for updates, let the good times flow! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@anncwb anncwb merged commit 76a879d into main Sep 12, 2024
13 checks passed
@anncwb anncwb deleted the bugfix/4366 branch September 12, 2024 14:04
WitMiao pushed a commit to WitMiao/vue-vben-admin that referenced this pull request Sep 12, 2024
kkfive pushed a commit to kkfive/vue-vben-admin that referenced this pull request Sep 14, 2024
@anncwb anncwb added the bug Something isn't working label Sep 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Form组件显示不全,移动端样式优化
1 participant