Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more component logic into modules #113

Open
vatro opened this issue Jun 22, 2022 · 0 comments
Open

Move more component logic into modules #113

vatro opened this issue Jun 22, 2022 · 0 comments
Assignees
Milestone

Comments

@vatro
Copy link
Owner

vatro commented Jun 22, 2022

During refactoring of the Mesh component, certain parts / blocks of logic became much larger, breaking 1.100 lines of code, that's too much / frustrating to review.

Currently, I'm generating the code of most of the components (except Canvas, WebGLRenderer and SvelthreeInteraction). While this made things much better concerning development speed / maintenance, the generator (private repo) already got too complicated / big with all the logic managed / generated via conditional string literals etc. A lot of functionality already lives inside utilities etc., still, the amount of generated code, logic / functionality in modules and the resulting components' bodies code amount is currently out of balance.

@vatro vatro self-assigned this Jun 22, 2022
@vatro vatro added this to the 1.0.0-next.X milestone Jun 22, 2022
@vatro vatro changed the title Start moving (bigger / shared) component logic into modules Start moving more reactivity related component logic into modules Jun 22, 2022
@vatro vatro changed the title Start moving more reactivity related component logic into modules Move more reactivity related component logic into modules Jun 22, 2022
@vatro vatro changed the title Move more reactivity related component logic into modules Move more component logic into modules Jul 3, 2022
@vatro vatro added the general General issue label Jul 3, 2022
vatro pushed a commit that referenced this issue Aug 9, 2022
- Refactored instance creation / recreation / premade instance injection logic
- Refactored shadow dom creation logic
- Moved some component logic to modules, see #113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant