Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All components need to be tested for instance injection and swapping #109

Closed
vatro opened this issue Jun 20, 2022 · 4 comments
Closed

All components need to be tested for instance injection and swapping #109

vatro opened this issue Jun 20, 2022 · 4 comments
Assignees
Milestone

Comments

@vatro
Copy link
Owner

vatro commented Jun 20, 2022

e.g.

import { _Mesh, _SpotLight, _PerspectiveCamera } from "svelthree"

const my_premade_mesh = new _Mesh(...)
const my_premade_spotlight = new _SpotLight(...)
const my_premade_camera = new _PerspectiveCamera(...)

...

<Mesh mesh={my_premade_mesh} />
<SpotLight light={my_premade_spotlight} />
<PerspectiveCamera camera={my_premade_camera} />

etc.

injection + swapping!

@vatro vatro added this to the 1.0.0-next.X milestone Jun 20, 2022
@vatro vatro self-assigned this Jun 20, 2022
@vatro vatro changed the title All components need to bested for instance injection All components need to be tested for instance injection Jun 20, 2022
@vatro vatro removed their assignment Jun 20, 2022
@vatro vatro added the good first issue Good for newcomers label Jun 20, 2022
@vatro vatro changed the title All components need to be tested for instance injection All components need to be tested for instance injection and swapping Jun 20, 2022
@vatro vatro modified the milestones: 1.0.0-next.X, 1.0.0-next.1 Aug 5, 2022
@vatro vatro mentioned this issue Aug 5, 2022
17 tasks
@vatro vatro self-assigned this Aug 5, 2022
@vatro vatro removed the good first issue Good for newcomers label Aug 5, 2022
@vatro
Copy link
Owner Author

vatro commented Aug 11, 2022

Tested:

  • Scene
  • Mesh
  • Points
  • AmbientLight
  • DirectionalLight
  • HemisphereLight
  • PointLight
  • RectAreaLight
  • SpotLight
  • OrthographicCamera
  • PerspectiveCamera

x CubeCamera -> #134
x Empty -> see #133
x LoadedGLTF -> see #124
x OrbitControls -> see #126

@vatro
Copy link
Owner Author

vatro commented Aug 12, 2022

so far, so good.

@vatro vatro closed this as completed Aug 12, 2022
@vatro
Copy link
Owner Author

vatro commented Aug 15, 2022

We have new Object3D and Group components that need to be tested.

  • Object3D
  • Group

@vatro vatro reopened this Aug 15, 2022
@vatro
Copy link
Owner Author

vatro commented Aug 15, 2022

so far, so good.

x CubeCamera -> #134
x LoadedGLTF -> see #124
x OrbitControls -> see #126

@vatro vatro closed this as completed Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant