feat(xen-api): cache support for call & callAsync #7853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-f
force-pushed
the
xapi-call-cache
branch
from
478ed77
to
9dc6e0f
Compare
MathieuRA
requested changes
Jul 23, 2024
MathieuRA
approved these changes
Jul 23, 2024
fbeauchamp
reviewed
Jul 24, 2024
don't take into account object equality
fbeauchamp
reviewed
Jul 24, 2024
julien-f
commented
Jul 24, 2024
| call: [ | ||
| cachable, | ||
| args => { | ||
| if (typeof args[0] !== 'string') { |
There was a problem hiding this comment.
Nope, it's not always a Map, it's a object that respect the Map interface, which opens the use with other libs like @isaacs/ttlcache or lru-cache.
julien-f
force-pushed
the
xapi-call-cache
branch
from
776eae0
to
7b5d439
Compare
fbeauchamp
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows to easily cache result of XAPI calls and will be used in various situations like #7751
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.md