Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-server/xo-web/host): display 2CRSi informations in general tab #7838

Merged
merged 12 commits into from
Jul 29, 2024
Merged

feat(xo-server/xo-web/host): display 2CRSi informations in general tab #7838

merged 12 commits into from
Jul 29, 2024

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Jul 16, 2024 •
edited
Loading

Screenshot

Capture d’écran du 2024-07-16 17-05-01

Description

Wait for #7853
Fixes #7816

Only Mona_1.44GG is supported
Tested with Cécile
The UI has been validated with Olivier L.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA self-assigned this Jul 16, 2024
@MathieuRA MathieuRA marked this pull request as ready for review July 16, 2024 14:35
fbeauchamp
fbeauchamp requested changes Jul 17, 2024
View reviewed changes
@xen-orchestra/xapi/host.mjs Outdated Show resolved Hide resolved
@xen-orchestra/xapi/host.mjs Outdated Show resolved Hide resolved
@xen-orchestra/xapi/host.mjs Outdated Show resolved Hide resolved
fbeauchamp
fbeauchamp requested changes Jul 19, 2024
View reviewed changes
@xen-orchestra/xapi/host.mjs Outdated Show resolved Hide resolved
@xen-orchestra/xapi/host.mjs Outdated Show resolved Hide resolved
@xen-orchestra/xapi/host.mjs Show resolved Hide resolved
@MathieuRA MathieuRA force-pushed the 2crsi-plugin branch 2 times, most recently from 9c7077f to 484bd67 Compare July 22, 2024 08:11
@MathieuRA MathieuRA removed the request for review from fbeauchamp July 22, 2024 14:13
@MathieuRA MathieuRA marked this pull request as draft July 24, 2024 13:30
@MathieuRA MathieuRA force-pushed the 2crsi-plugin branch 2 times, most recently from 9916940 to 80d5a73 Compare July 24, 2024 13:37
@MathieuRA MathieuRA marked this pull request as ready for review July 24, 2024 14:27
fbeauchamp
fbeauchamp requested changes Jul 24, 2024
View reviewed changes
@xen-orchestra/xapi/host.mjs Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from julien-f July 25, 2024 09:24
@MathieuRA MathieuRA requested a review from julien-f July 25, 2024 12:47
@MathieuRA MathieuRA marked this pull request as draft July 25, 2024 14:41
@MathieuRA MathieuRA requested a review from julien-f July 25, 2024 15:11
@MathieuRA MathieuRA requested a review from julien-f July 25, 2024 15:23
@MathieuRA MathieuRA requested a review from julien-f July 25, 2024 15:34
julien-f
julien-f reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Server-side LGTM

@MathieuRA MathieuRA marked this pull request as ready for review July 29, 2024 15:29
@MathieuRA MathieuRA merged commit e30f289 into master Jul 29, 2024
1 check passed
@MathieuRA MathieuRA deleted the 2crsi-plugin branch July 29, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-f julien-f julien-f left review comments

@fbeauchamp fbeauchamp fbeauchamp approved these changes

Assignees

@MathieuRA MathieuRA

Labels
Highlight
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initial hardware info on 2CRSi servers
3 participants
@MathieuRA @fbeauchamp @julien-f