Refresher pre & post refresh GHK with checkbox control #12890
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 12260-refreshPre&PostwithControls
… 12260-refreshPre&PostwithControls
…s' into 12260-refreshPre&PostwithControls
… 12260-refreshPre&PostwithControls
…fresh is opt-in, PDS referesh is opt-out. Deck refresh options are formatted to distinguish them from main options.
…stPreControls2 # Conflicts: # vassal-app/src/main/java/VASSAL/build/module/GameRefresher.java # vassal-doc/src/main/readme-referencemanual/ReferenceManual/GameRefresher.adoc
riverwanderer
changed the title
|
Revised PR with enhanced control. Simple test performed with Action Button report showing that Pre / Post GHKs work only when the HK control checkbox is selected on the refresher panel. Previous test has shown that a complex piece replacement worked in a PDS refresh run (C&C Nap module v4.2, replacing the scenario text label). Refresh Help updated but a further update is needed to add the Refresh option into the options list. |
riverwanderer
added
the
Awaiting Testing/Feedback
…verwanderer/vassal into 12260-refreshPostPreControls2 # Conflicts: # vassal-doc/src/main/readme-referencemanual/ReferenceManual/GameRefresher.adoc
… Rationalise option settings. Attempt to close (dispose) options window at the end of processing.
…rmat (deck) sub-options. Make delete no map pieces default (consistent with Refresh Counters). Rationalise option settings & use constants always. Doc spelling & grammar tweaks.
…ssal into 12260-refreshPostPreControls2 # Conflicts: # vassal-app/src/main/java/VASSAL/build/module/GameRefresher.java # vassal-doc/src/main/readme-referencemanual/ReferenceManual/GameRefresher.adoc
|
Superceded by #12898. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-attempt to build with refresher panel controls. Replaces PR #12719.