fix: bump mehari to escape clinvar output string (#485) #488
Conversation
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant varfish-server-worker
participant mehari
participant aws-sdk-s3
User->>varfish-server-worker: Request functionality
varfish-server-worker->>mehari: Use updated version
varfish-server-worker->>aws-sdk-s3: Access S3 service
aws-sdk-s3-->>varfish-server-worker: Provide data
varfish-server-worker-->>User: Return response
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
- Cargo.toml (2 hunks)
🧰 Additional context used
🔇 Additional comments (1)
Cargo.toml (1)
19-19: LGTM: Formatting correction for aws-sdk-s3 dependencyThe removal of the leading hyphen from the aws-sdk-s3 dependency line is a correct formatting adjustment. This change improves consistency with other dependency declarations in the file.
| @@ -39,7 +39,7 @@ hgvs = "0.17.3" | |||
| indexmap = { version = "2.6", features = ["serde"] } | |||
| itertools = "0.13" | |||
| log = "0.4" | |||
| mehari = "0.29.0" | |||
| mehari = "0.29.5" | |||
There was a problem hiding this comment.
💡 Codebase verification
Issue: Missing changelog entry for mehari version 0.29.5
While the mehari dependency has been updated to version 0.29.5 with several references to ClinVar in the codebase, there is no corresponding entry in the CHANGELOG.md. Please ensure that the changelog is updated to reflect these changes to maintain proper documentation and transparency.
🔗 Analysis chain
Approved: mehari dependency update to address ClinVar output string issue
The update of the mehari dependency from version 0.29.0 to 0.29.5 aligns with the PR objective to address the ClinVar output string issue. This minor version update suggests backward compatibility, which is good for maintaining stability.
To ensure this update fully addresses the intended issue and doesn't introduce any breaking changes, please run the following script to check the changelog or release notes for mehari 0.29.5:
Please review the output to confirm that the update addresses the ClinVar output string issue and doesn't introduce any breaking changes.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the changelog for mehari 0.29.5
# Test: Check if there's a CHANGELOG.md file in the project root
if [ -f CHANGELOG.md ]; then
echo "Checking local CHANGELOG.md for mehari 0.29.5 updates"
sed -n '/## \[0.29.5\]/,/## \[0.29.4\]/p' CHANGELOG.md
else
echo "Local CHANGELOG.md not found. Fetching from GitHub..."
gh repo view mehari-rs/mehari --json url -q .url | xargs -I {} gh api {}/contents/CHANGELOG.md --jq .content | base64 -d | sed -n '/## \[0.29.5\]/,/## \[0.29.4\]/p'
fi
# Test: Search for mentions of ClinVar-related changes
echo "Searching for ClinVar-related changes in mehari 0.29.5"
rg --type rust "clinvar" -C 5
Length of output: 56441
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #488 +/- ##
===================================
Coverage 74% 74%
===================================
Files 42 42
Lines 7365 7365
===================================
Hits 5470 5470
Misses 1895 1895 |
Summary by CodeRabbit
meharidependency version to enhance performance and stability.aws-sdk-s3dependency line for improved clarity.