Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor internal data structures of seqvar query schema #374

Closed
holtgrewe opened this issue Jun 18, 2024 · 0 comments
Closed

Refactor internal data structures of seqvar query schema #374

holtgrewe opened this issue Jun 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@holtgrewe
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The seqvar query schema data structures are pretty flat. We should structure them more deeply to prevent dozens of attributes. The main offenders are CaseQuery, SequenceVariant (not part of query, but internal data structure)

Describe the solution you'd like
For CaseQuery:

  • consequences..genotype - keep
  • transcripts_coding, transcripts_noncoding, max_exon_dist - move to TranscriptRelated
  • var_type_* - move to VariantTypeRelated
  • gene_allowlist, genomic_regions - move to LocusRelated
  • require_in_clinvar, clinvar_* - move to ClinvarRelated
  • gnomad_*, helixmtdb_* - move to PopulationFrequencyRelated
  • inhouse_* - move to InhouseFrequencyRelated

For SequenceVariant:

  • chrom..ann_fields - keep
  • gnomad_exomes_an..helix_het - move to PopulationFrequencies struct, rename helix_* to helixmtdb_*
  • inhouse_an..inhouse_hemi - move to InhouseFrequencies struct
  • call_info - keep, move up behind ann_fields

Describe alternatives you've considered
N/A

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants