Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor seqvar query query schema and use protobuf for input #373

Closed
holtgrewe opened this issue Jun 18, 2024 · 0 comments
Closed

Refactor seqvar query query schema and use protobuf for input #373

holtgrewe opened this issue Jun 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@holtgrewe
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We currently use JSON serde-serialized data structures for the query schema in seqvars query. This requires us to replicate the schema data structure on the Python side. Further, there is a 1:1 relation between the input and the internal data structures.

Describe the solution you'd like

  • Provide a protobuf schema file for the query definition data structures.
  • Use prost to obtain Rust data structures from them.
  • Read such protobuf from JSON using pbjson.
  • Convert them to the internal data structures.
  • Run the program as currently.

Describe alternatives you've considered
N/A

Additional context
The data structures for representing queries are defined in seqvars/query/schema.rs. The seqvars query command is currently not called from the Python server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants