Skip to content

fix: update noodles group #643

fix: update noodles group

fix: update noodles group #643

GitHub Actions / clippy succeeded May 7, 2024 in 0s

clippy

7 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 7
Note 0
Help 0

Versions

  • rustc 1.78.0 (9b00956e5 2024-04-29)
  • cargo 1.78.0 (54d8815d0 2024-03-26)
  • clippy 0.1.78 (9b00956 2024-04-29)

Annotations

Check warning on line 260 in src/tsv/coding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `Clone::clone()` may be inefficient

warning: assigning the result of `Clone::clone()` may be inefficient
   --> src/tsv/coding.rs:260:21
    |
260 |                     res.alternative = alternative.clone();
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `res.alternative.clone_from(alternative)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

Check warning on line 251 in src/tsv/coding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `Clone::clone()` may be inefficient

warning: assigning the result of `Clone::clone()` may be inefficient
   --> src/tsv/coding.rs:251:21
    |
251 |                     res.reference = reference.clone();
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `res.reference.clone_from(reference)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

Check warning on line 224 in src/tsv/coding.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `Clone::clone()` may be inefficient

warning: assigning the result of `Clone::clone()` may be inefficient
   --> src/tsv/coding.rs:224:21
    |
224 |                     res.chrom = chrom.clone();
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `res.chrom.clone_from(chrom)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
    = note: `#[warn(clippy::assigning_clones)]` on by default

Check warning on line 83 in src/gnomad_sv/cli/import/gnomad_sv4.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

direct implementation of `ToString`

warning: direct implementation of `ToString`
  --> src/gnomad_sv/cli/import/gnomad_sv4.rs:66:1
   |
66 | / impl ToString for Population {
67 | |     fn to_string(&self) -> String {
68 | |         match self {
69 | |             Population::Afr => "AFR",
...  |
82 | |     }
83 | | }
   | |_^
   |
   = help: prefer implementing `Display` instead
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl

Check warning on line 63 in src/gnomad_sv/cli/import/gnomad_sv2.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

direct implementation of `ToString`

warning: direct implementation of `ToString`
  --> src/gnomad_sv/cli/import/gnomad_sv2.rs:51:1
   |
51 | / impl ToString for Population {
52 | |     fn to_string(&self) -> String {
53 | |         match self {
54 | |             Population::Afr => "AFR",
...  |
62 | |     }
63 | | }
   | |_^
   |
   = help: prefer implementing `Display` instead
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl

Check warning on line 62 in src/gnomad_sv/cli/import/gnomad_cnv4.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

direct implementation of `ToString`

warning: direct implementation of `ToString`
  --> src/gnomad_sv/cli/import/gnomad_cnv4.rs:48:1
   |
48 | / impl ToString for Population {
49 | |     fn to_string(&self) -> String {
50 | |         match self {
51 | |             Population::Afr => "AFR".to_string(),
...  |
61 | |     }
62 | | }
   | |_^
   |
   = help: prefer implementing `Display` instead
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
   = note: `#[warn(clippy::to_string_trait_impl)]` on by default

Check warning on line 25 in src/server/actix_server/annos_db_info.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

struct `ResultEntry` is never constructed

warning: struct `ResultEntry` is never constructed
  --> src/server/actix_server/annos_db_info.rs:25:8
   |
25 | struct ResultEntry {
   |        ^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default