fix: update noodles group #643
conventional-prs.yml
on: pull_request_target
title-format
3s
Annotations
1 error and 7 warnings
title-format
Unknown release type "enhancement" found in pull request title "enhancement: update noodles group".
Available types:
- feat: A new feature
- fix: A bug fix
- docs: Documentation only changes
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
- refactor: A code change that neither fixes a bug nor adds a feature
- perf: A code change that improves performance
- test: Adding missing tests or correcting existing tests
- build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
- ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
- chore: Other changes that don't modify src or test files
- revert: Reverts a previous commit
|
assigning the result of `Clone::clone()` may be inefficient:
src/tsv/coding.rs#L260
warning: assigning the result of `Clone::clone()` may be inefficient
--> src/tsv/coding.rs:260:21
|
260 | res.alternative = alternative.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `res.alternative.clone_from(alternative)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
|
assigning the result of `Clone::clone()` may be inefficient:
src/tsv/coding.rs#L251
warning: assigning the result of `Clone::clone()` may be inefficient
--> src/tsv/coding.rs:251:21
|
251 | res.reference = reference.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `res.reference.clone_from(reference)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
|
assigning the result of `Clone::clone()` may be inefficient:
src/tsv/coding.rs#L224
warning: assigning the result of `Clone::clone()` may be inefficient
--> src/tsv/coding.rs:224:21
|
224 | res.chrom = chrom.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `res.chrom.clone_from(chrom)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default
|
direct implementation of `ToString`:
src/gnomad_sv/cli/import/gnomad_sv4.rs#L66
warning: direct implementation of `ToString`
--> src/gnomad_sv/cli/import/gnomad_sv4.rs:66:1
|
66 | / impl ToString for Population {
67 | | fn to_string(&self) -> String {
68 | | match self {
69 | | Population::Afr => "AFR",
... |
82 | | }
83 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
|
direct implementation of `ToString`:
src/gnomad_sv/cli/import/gnomad_sv2.rs#L51
warning: direct implementation of `ToString`
--> src/gnomad_sv/cli/import/gnomad_sv2.rs:51:1
|
51 | / impl ToString for Population {
52 | | fn to_string(&self) -> String {
53 | | match self {
54 | | Population::Afr => "AFR",
... |
62 | | }
63 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
|
direct implementation of `ToString`:
src/gnomad_sv/cli/import/gnomad_cnv4.rs#L48
warning: direct implementation of `ToString`
--> src/gnomad_sv/cli/import/gnomad_cnv4.rs:48:1
|
48 | / impl ToString for Population {
49 | | fn to_string(&self) -> String {
50 | | match self {
51 | | Population::Afr => "AFR".to_string(),
... |
61 | | }
62 | | }
| |_^
|
= help: prefer implementing `Display` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
= note: `#[warn(clippy::to_string_trait_impl)]` on by default
|
struct `ResultEntry` is never constructed:
src/server/actix_server/annos_db_info.rs#L25
warning: struct `ResultEntry` is never constructed
--> src/server/actix_server/annos_db_info.rs:25:8
|
25 | struct ResultEntry {
| ^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|