Add @unchecked Sendable to Todo #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahdiBM
reviewed
Apr 29, 2024
| /// Property wrappers interact poorly with `Sendable` checking, causing a warning for the `@ID` property | ||
| /// It is recommended you write your model with sendability checking on and then suppress the warning | ||
| /// afterwards with `@unchecked Sendable`. | ||
| final class Todo: Model, Content, @unchecked Sendable { | ||
| static let schema = "todos" |
There was a problem hiding this comment.
This one's better with the conment (compared to @gwynne's).
MahdiBM
approved these changes
Apr 29, 2024
gwynne
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per vapor/vapor#3180 and vapor/fluent-kit#601, the recent update to Fluent to add (nearly but not totally complete)
Sendable-correctness results in a new warning of the formStored property '_id' of 'Sendable'-conforming class 'Todo' is mutablefor all types conforming toFields,Schema, and/orModel. This adds the appropriate annotation to the template'sTodomodel for sample purposes.(@gwynne wrote this)