-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Primary Sendable support for Fluent #601
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…but holding off on that just in case)
…s will not be fun for performance.
…ory, Databases, Migrations, and Migrator all Sendable.
… tests accordingly
0xTim
requested changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change I want, the rest I can live with.
Not overly happy with the property wrappers requiring unchecked, especially given the lack of access management internally but we don't have a huge amount of leeway here.
Very happy to drop 5.9 though
gwynne
changed the title
[WIP] Partial Sendable support for Fluent
Primary Sendable support for Fluent
Apr 26, 2024
0xTim
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 1.48.0
Adds as much
Sendable
correctness to FluentKit as it is possible to add.Important
It was not possible to make
Model
correctlySendable
due to limitations of how property wrappers work, even though the wrappers themselves areSendable
. Users can get around this by adding@unchecked Sendable
to each individualModel
class, but this of course does not confer actual safety; it just disables the compiler's warnings.Also adds some missing APIs to
FluentSQL
to allow encoding Fluent models to SQLKit queries. The existing APIs for decoding Fluent models from SQLKit queries have been renamed, and the old names deprecated.Other changes:
Mirror
are now used in Swift 5.10QueryHistory
is no longer thread-unsafe for readingSomeCodingKey
is now an alias for SQLKit's version