fluent 1.0.0 gm, add decoders + sql updates #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 2, 2018
Closed
|
Any timeline to merge this? Or should I start pointing to this branch? Just tried doing
|
tanner0101
changed the title
Cellane
reviewed
Jun 9, 2018
| /// Creates a new `PostgreSQLDatabaseConfig`. | ||
| public init(serverAddress: ServerAddress, username: String, database: String? = nil, password: String? = nil, transport: PostgreSQLTransportConfig = .cleartext) { | ||
| self.serverAddress = serverAddress | ||
| public init(serverAddress: PostgreSQLConnection.ServerAddress, username: String, database: String? = nil, password: String? = nil, transport: PostgreSQLConnection.TransportConfig = .cleartext) { |
There was a problem hiding this comment.
A cosmetic thing but the indentation is wrong for this method, somehow tabs sneaked into a project indented by spaces.
| guard let url = URL(string: urlString), | ||
| let hostname = url.host, | ||
| let port = url.port, | ||
| let username = url.user, | ||
| let database = url.databaseName, | ||
| url.path.count > 0 |
There was a problem hiding this comment.
This check (url.path.count > 0) is probably not necessary since the previous line will already guarantee that database name was supplied as a part of the connection string?
|
Hey @tanner0101, you just merged a pull request, have a coin! You now have 705 coins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.