Migrating psql DB fails when using Decimal type on models

[NZTimKeegan]

Expected Behavior

Database should be created including column for Decimal property

Actual Behavior

Thread 1: Fatal error points to line 179 of the file Decodable+CodingPath.swift (path: Core 3.0.0-rc.1.0.1/CodableKit/Key)

With logging enabled:

databaseConfig.enableLogging(on: .psql)

the output is:

Migrating psql DB
[psql] [2018-03-20 20:39:24 +0000] SELECT count(*) as "fluentAggregate" FROM "fluent" []
[psql] [2018-03-20 20:39:24 +0000] SELECT "fluent".* FROM "fluent" ORDER BY "fluent"."batch" DESC LIMIT 1 OFFSET 0 []
[psql] [2018-03-20 20:39:24 +0000] SELECT "fluent".* FROM "fluent" WHERE ("fluent"."name" = $1) LIMIT 1 OFFSET 0 ["7 bytes"]
[psql] [2018-03-20 20:39:24 +0000] SELECT "fluent".* FROM "fluent" WHERE ("fluent"."name" = $1) LIMIT 1 OFFSET 0 ["6 bytes"]
[psql] [2018-03-20 20:39:24 +0000] SELECT "fluent".* FROM "fluent" WHERE ("fluent"."name" = $1) LIMIT 1 OFFSET 0 ["18 bytes"]
[psql] [2018-03-20 20:39:24 +0000] SELECT "fluent".* FROM "fluent" WHERE ("fluent"."name" = $1) LIMIT 1 OFFSET 0 ["13 bytes"]

Steps to Reproduce the Problem

1. Create new project (e.g. vapor new api-template --template=api --branch=beta )
2. Add Postgres config
3. Add decimal property to model

import FluentPostgreSQL
import Foundation
import Vapor

struct Todo: Content, Migration, Parameter, PostgreSQLModel {
  var id: Int?
  var decimal: Decimal
}

1. Hit Run
   

Specifications

• Versions:
  • Vapor Toolbox 3.1.4
  • Swift 4.1
  • Xcode 9.3 beta 4

[tanner0101]

Decimal encodes to JSON, like:

{"exponent":-3,"length":1,"isCompact":true,"isNegative":true,"mantissa":[1234,0,0,0,0,0,0,0]} (JSONB)

This is desired since it allows the type to store values with higher precision than Float and Double. I've added a test to make sure this is working in the latest build, just make sure to use a JSONB column type 👍 .