Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix playback speed issue on certain detected media #137

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Fix playback speed issue on certain detected media #137

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51e2e9c
fix playback speed issue on certain detected media
Quantizr Mar 9, 2023
f2e29c4
Prevent unnecessary creation of MutationObservers
Quantizr Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions src/contents/lib/SpeedController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import debugging from "debug"
import inspectMediaElements from "./inspectMediaElements"

import type { MediaElement } from "../../shared/types"

Expand Down Expand Up @@ -100,18 +101,7 @@ export default class SpeedController {
}

setPlaybackRate(rate: number) {
this.elements = [
...document.querySelectorAll("video, audio")
] as MediaElement[]
debug(
"Setting playback rate to",
rate,
"on",
this.elements.length,
"elements"
)

this.elements.forEach((element) => {
inspectMediaElements((element: MediaElement) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates a new MutationObserver each time it is called, which should result in a resource leak.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using inspectMediaElements inside setPlaybackRate will call the function every time the speed should change and attach a new MutationObserver.
Due to this, we might have 100s to 1000s of MutationObservers after long videos which would be a performance issue and we'll also have a memory leak in the callback function as it will be called every time a new element appears for each observer.

I'd suggest instead creating a central inspectMediaElements in the SpeedController constructor and have it update this.elements dynamically instead.

this.setPlaybackRateForElement(rate, element)
})
}
Expand Down