Fix playback speed issue on certain detected media #137
Conversation
src/contents/lib/SpeedController.ts
Outdated
| ) | ||
|
|
||
| this.elements.forEach((element) => { | ||
| inspectMediaElements((element: MediaElement) => { |
There was a problem hiding this comment.
This creates a new MutationObserver each time it is called, which should result in a resource leak.
src/contents/lib/SpeedController.ts
Outdated
| ) | ||
|
|
||
| this.elements.forEach((element) => { | ||
| inspectMediaElements((element: MediaElement) => { |
There was a problem hiding this comment.
Using inspectMediaElements inside setPlaybackRate will call the function every time the speed should change and attach a new MutationObserver.
Due to this, we might have 100s to 1000s of MutationObservers after long videos which would be a performance issue and we'll also have a memory leak in the callback function as it will be called every time a new element appears for each observer.
I'd suggest instead creating a central inspectMediaElements in the SpeedController constructor and have it update this.elements dynamically instead.
Moved inspectMediaElements to the constructor where it dynamically updates this.elements
|
Hopefully that's what you meant? I'm not really familiar with JS |
|
Yes looks good now - thank you again for the contribution! |
Fixes #136 where certain media types would not be detected by
document.querySelectorAll("video, audio")