Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stray .d.ts file #1215

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Remove stray .d.ts file #1215

merged 3 commits into from
Nov 9, 2023

Conversation

mrm007
Copy link
Contributor

@mrm007 mrm007 commented Nov 8, 2023

It was missed in #1197

Copy link

changeset-bot bot commented Nov 8, 2023

🦋 Changeset detected

Latest commit: 9e1ac68

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@vanilla-extract/css Patch
@fixtures/features Patch
@fixtures/layers Patch
@fixtures/low-level Patch
@fixtures/recipes Patch
@fixtures/sprinkles Patch
@fixtures/themed Patch
@fixtures/unused-modules Patch
vanilla-extract-example-webpack-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@askoufis askoufis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That change was also never released. IMO it should've been, but 🤷.

@mrm007
Copy link
Contributor Author

mrm007 commented Nov 8, 2023

@askoufis now we have a changeset

@askoufis askoufis enabled auto-merge (squash) November 9, 2023 03:01
Copy link
Contributor

@mattcompiles mattcompiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrm007! 🍻
I actually added it but it got forced pushed over and I didn't realise 🤷

@askoufis askoufis merged commit 911c8b7 into master Nov 9, 2023
11 checks passed
@askoufis askoufis deleted the clean-up branch November 9, 2023 03:04
@brandonpittman
Copy link
Contributor

brandonpittman commented Nov 10, 2023

#1197

Did my PR not get included with in the release?

@askoufis
Copy link
Contributor

#1197

Did my PR not get included with in the release?

Your changes have been released. The release is pointing to the PR that added the changeset.

@brandonpittman
Copy link
Contributor

#1197
Did my PR not get included with in the release?

Your changes have been released. The release is pointing to the PR that added the changeset.

Thanks. The notes mentioned someone else as fixing it and I wondered if my PR disappeared into the ether. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants