Use modern-ahocorasick #1197
Merged
Use modern-ahocorasick #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mattcompiles
approved these changes
Oct 12, 2023
|
@brandonpittman looks like the lockfile is invalid. Maybe a different pnpm version? |
|
It did look like it updated the lockfile version. |
brandonpittman
force-pushed
the
master
branch
from
2a4b3d5
to
aedefdc
Compare
|
@mattcompiles Lowered my local PNPM version to match the repo's. Seems like it sorted out the lockfile changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
ahocorasickpackage doesn't export anything which can cause issues with certain frameworks. Themodern-ahocorasickpackage has the same API as the old one but actually exports something instead of adding to the global namespace.