Do not keep empty Node actions in serialized output
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
requested review from
a team,
ruksi and
magdapoppins
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 93.50% 93.54% +0.03%
==========================================
Files 47 47
Lines 1325 1333 +8
Branches 177 178 +1
==========================================
+ Hits 1239 1247 +8
Misses 44 44
Partials 42 42
Continue to review full report at Codecov.
|
akx
force-pushed
the
no-serialize-empty-actions
branch
from
5129ba8 to
6578713
Compare
There's no need to have the optional empty list there if the input maybe wasn't there in the first place.
akx
force-pushed
the
no-serialize-empty-actions
branch
from
6578713 to
641bc3b
Compare
ruksi
approved these changes
Nov 4, 2021
Comment on lines
+46
to
+47
| if not ser.get('actions'): | ||
| ser.pop('actions', None) |
There was a problem hiding this comment.
if actions falsy or non-existent, try to remove actions from the dict
the code could signify intent a bit more but that is mainly a personal preference 🤔
such a tiny snippet anyway + a test to back it up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to have the optional empty list there if the input maybe wasn't there in the first place.
This is currently breaking a test in valohai/valohai-utils#75 since valohai-yaml got bumped to 0.20.0 there.