Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not keep empty Node override in serialized output #113

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

akx
Copy link
Member

@akx akx commented Sep 4, 2023

Analogue of 641bc3b.

Refs #59.

@akx akx requested review from tokkoro and a user September 4, 2023 12:03
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2023

Codecov Report

Merging #113 (7126c5f) into master (a42fb80) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
+ Coverage   92.51%   92.56%   +0.04%     
==========================================
  Files          61       61              
  Lines        1870     1882      +12     
  Branches      317      318       +1     
==========================================
+ Hits         1730     1742      +12     
  Misses         70       70              
  Partials       70       70              
Files Changed Coverage Δ
tests/test_pipeline.py 92.50% <100.00%> (+1.59%) ⬆️
valohai_yaml/objs/pipelines/execution_node.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akx akx merged commit d0b2009 into master Sep 4, 2023
@akx akx deleted the dont-serialize-empty-override branch September 4, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants