Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added geosearch tests #97

Merged
merged 2 commits into from
Sep 21, 2024
Merged

Conversation

mkmkme
Copy link
Collaborator

@mkmkme mkmkme commented Sep 20, 2024

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

This PR contains two commits. The first one adds a missing assert keyword to some of test_geosearch_member checks. The second one adds async geosearch tests by copying and adapting the sync ones.

Fixes #63

These lines were missing the `assert` keyword and hence were
meaningless.

Signed-off-by: Mikhail Koviazin <[email protected]>
@mkmkme
Copy link
Collaborator Author

mkmkme commented Sep 20, 2024

Oops, the type hints were too modern for some Python versions we support. I'll fix them promptly.

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.17%. Comparing base (c8c19c2) to head (3fee241).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   75.12%   75.17%   +0.05%     
==========================================
  Files         132      132              
  Lines       34398    34480      +82     
==========================================
+ Hits        25840    25922      +82     
  Misses       8558     8558              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

These tests were copied from the sync tests and adapted to use the async
client.

This commit fixes #63

Signed-off-by: Mikhail Koviazin <[email protected]>
Copy link
Collaborator

@ahmedsobeh ahmedsobeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mkmkme mkmkme merged commit dcc1713 into valkey-io:main Sep 21, 2024
84 checks passed
@mkmkme mkmkme deleted the mkmkme/async-geosearch-tests branch September 23, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add tests for geosearch in async tests
3 participants