Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for geosearch in async tests #63

Closed
kjaymiller opened this issue Jul 31, 2024 · 0 comments · Fixed by #97
Closed

add tests for geosearch in async tests #63

kjaymiller opened this issue Jul 31, 2024 · 0 comments · Fixed by #97

Comments

@kjaymiller
Copy link
Contributor

Version: 6.0.0b

Platform: MacOS ARM M2 pro

Description:

In #61, I updated the repo on the sync and async side for the geo commands in valkey-py.

These commands are:

  • georadius and georadiusmember (both deprecated)
  • geosearch

The sync tests have tests for all three but the async tests only cover georadius and georadiusmember.

I propose adding the tests for geosearch to the async side to have parity in testing across the platforms (UNLESS there is a reason that geosearch is not testes in the async implementations)

@mkmkme mkmkme mentioned this issue Sep 20, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant