Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a single validation function around the service_uri #29

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

ahmedsobeh
Copy link
Collaborator

@ahmedsobeh ahmedsobeh commented Jun 30, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Created url_parser and removed duplication of parse_url. This PR resolves issue #25

I created a url_parser module and added it to the parsers folder. I then used this module in both connection modules (the normal one and the asyncio one) and updated the tests accordingly.

Copy link
Member

@aiven-sal aiven-sal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I squashed and rebased some commits and will merge as soon as the CI completes

@aiven-sal aiven-sal merged commit 01db8ba into main Jul 3, 2024
47 checks passed
@aiven-sal aiven-sal deleted the issue-25 branch July 3, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants