-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds protocol support for redis
and rediss
#27
Conversation
Signed-off-by: Jay Miller <[email protected]>
Signed-off-by: Jay Miller <[email protected]>
Signed-off-by: Jay Miller <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
=======================================
Coverage ? 75.05%
=======================================
Files ? 131
Lines ? 34386
Branches ? 0
=======================================
Hits ? 25807
Misses ? 8579
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I have a couple of requests:
- could you squash the lint changes in your second commit in the first one? It would make it easier for me to review commit-by-commit.
- ignore the CHANGES file, it wasn't really used much recently and we have a nice bot that can summarize changes in releases from PRs. It isn't perfect, but for now let's just use that (you don't have to do anything).
Signed-off-by: Jay Miller <[email protected]>
Signed-off-by: Jay Miller <[email protected]>
Signed-off-by: Jay Miller <[email protected]>
Signed-off-by: Jay Miller <[email protected]>
I hope I did this correctly |
@aiven-sal - Is there something on my end holding progress on this? |
Nope, there is some related work going on in #29, so I'm waiting for it to get merged. Then this will need to be rebased (I'm sorry for the inconvenience). |
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
resolves #26 #23