Java: Move ExamplesApp to examples folder #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Closed
yipin-chen
reviewed
Jul 9, 2024
Yury-Fridlyand
added
java
acarbonetto
commented
Jul 9, 2024
acarbonetto
commented
Jul 9, 2024
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
yipin-chen
approved these changes
Jul 10, 2024
barshaul
approved these changes
Jul 10, 2024
This will come in a follow-up PR. This PR is just to move away from the client gradle project and allow users to download from Maven. |
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
| @@ -155,6 +155,46 @@ Some troubleshooting issues: | |||
| - If build fails because of rust compiler fails, make sure submodules are updated using `git submodule update`. | |||
| - If protobuf 26.0 or earlier is detected, upgrade to the latest protobuf release. | |||
|
|
|||
| ## Running Examples App | |||
There was a problem hiding this comment.
Wouldn't this be useful for users of GLIDE to know? I feel like this is less DEVELOPER.MD material and more README.MD material. I put instructions for running the Scala and Kotlin examples in the README in my PR for that reason, but even if you disagree, I think we should be aligned at the very least.
There was a problem hiding this comment.
I will like to the examples/java/README.md from the jave/README.md and give a short blurb. You are correct that it would be useful to have.
But this level of detail (publishing to local maven) is not necessary in the README.md
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
5 tasks
jonathanl-bq
pushed a commit
to jonathanl-bq/glide-for-redis
that referenced
this pull request
Jul 12, 2024
* Java: Move ExamplesApp to examples folder Signed-off-by: Andrew Carbonetto <[email protected]> * Update gradle build to send version Signed-off-by: Andrew Carbonetto <[email protected]> * Fix comment Signed-off-by: Andrew Carbonetto <[email protected]> * Update build artefact names Signed-off-by: Andrew Carbonetto <[email protected]> * Update build.gradle to allow for custom classifier Signed-off-by: Andrew Carbonetto <[email protected]> * Update examples with osdetector Signed-off-by: Andrew Carbonetto <[email protected]> * Update build for review comments Signed-off-by: Andrew Carbonetto <[email protected]> * Remove unnecessary dependencies in the java example Signed-off-by: Andrew Carbonetto <[email protected]> * Clean up links in readme Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.