-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Java examples #1907
Added Java examples #1907
Conversation
Signed-off-by: Yi-Pin Chen <[email protected]>
41586b7
to
32694d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a readme which describes how to run those
That readme can have links to java client readme or dev.md files
Signed-off-by: Yi-Pin Chen <[email protected]>
Signed-off-by: Yi-Pin Chen <[email protected]>
Signed-off-by: Yi-Pin Chen <[email protected]>
I'm about to move the examples folder. We can combine this into the moving PR to make sure we don't lose things. Stay tuned. |
@yipin-chen can you update for: #1908 |
Ok. I see your changes in #1908. I will delete my README.md. What other changes do you want me to do? |
|
||
import static glide.api.models.GlideString.gs; | ||
|
||
public class Main { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change the file name and Main
to ClusterExample
|
||
import static glide.api.models.GlideString.gs; | ||
|
||
public class Main { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will change the file name and Main
to StandaloneExample
|
||
import static glide.api.models.GlideString.gs; | ||
|
||
public class Main { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Please add java doc to the example - explaining what the example is doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a gradle files there?
I also consider deleting existing example, since it is a duplicate
I will update this PR once #1908 is merged. |
Copying my comment from #1908:
|
Close this PR and create a new PR. |
Added standalone and cluster examples for Java.