Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Java examples #1907

Closed
wants to merge 4 commits into from

Conversation

yipin-chen
Copy link
Collaborator

Added standalone and cluster examples for Java.

@yipin-chen yipin-chen added the java issues and fixes related to the java client label Jul 9, 2024
@yipin-chen yipin-chen requested a review from a team as a code owner July 9, 2024 20:51
Signed-off-by: Yi-Pin Chen <[email protected]>
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a readme which describes how to run those
That readme can have links to java client readme or dev.md files

Signed-off-by: Yi-Pin Chen <[email protected]>
Signed-off-by: Yi-Pin Chen <[email protected]>
Signed-off-by: Yi-Pin Chen <[email protected]>
@acarbonetto
Copy link
Collaborator

I'm about to move the examples folder. We can combine this into the moving PR to make sure we don't lose things. Stay tuned.

@acarbonetto
Copy link
Collaborator

@yipin-chen can you update for: #1908

@yipin-chen
Copy link
Collaborator Author

@yipin-chen can you update for: #1908

Ok. I see your changes in #1908. I will delete my README.md. What other changes do you want me to do?


import static glide.api.models.GlideString.gs;

public class Main {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change the file name and Main to ClusterExample


import static glide.api.models.GlideString.gs;

public class Main {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change the file name and Main to StandaloneExample


import static glide.api.models.GlideString.gs;

public class Main {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Please add java doc to the example - explaining what the example is doing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

@Yury-Fridlyand Yury-Fridlyand added the docs Documentation label Jul 9, 2024
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a gradle files there?
I also consider deleting existing example, since it is a duplicate

@yipin-chen
Copy link
Collaborator Author

I will update this PR once #1908 is merged.

@Yury-Fridlyand
Copy link
Collaborator

Copying my comment from #1908:

I propose to add (to readme and/or as separate files) scala and kotlin examples created by @jonathanl-bq.

@yipin-chen
Copy link
Collaborator Author

Close this PR and create a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation java issues and fixes related to the java client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants