-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolated at en #18
Isolated at en #18
Conversation
src/openqdc/datasets/nabladft.py
Outdated
def __init__(self, energy_unit=None, distance_unit=None) -> None: | ||
super().__init__(energy_unit=energy_unit, distance_unit=distance_unit) | ||
# Energy in hartree, all zeros by default | ||
atomic_energies = np.zeros((MAX_ATOMIC_NUMBER,), dtype=np.float32) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we set all atomic energies to zeros here? don't we have them calculated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current atomic energies workflow implemented in main is wrong as we are not getting the isolated atom energies considering the formal charge of the atom.
Right now the energies are indexed by the chemical number but this is not taking account that elements with different charges have different energies, so we should be indexing by a Tuple(Chemical species, Formal Charge)
This is a workaround to continue using the package while I take care about it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented a way to get the correct e0 considering the formal charges. See 928716b
Implemented:
|
Various stuffs:
Other things:
To do :