Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vscode): update Solidity formatter and package defaults #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

3esmit
Copy link

@3esmit 3esmit commented Sep 13, 2024

Description

Apply config suggested by foundry in https://book.getfoundry.sh/config/vscode

We actually should discuss if the change of solidity formatter is a good suggestion from the docs.
JuanBlanco.solidity is the most popular, but NomicFoundation.hardhat-solidity seem to integrate better. Just for example, JuanBlanco.solidity does not follow the solc defined in foundry.toml, which made me create this pre-commit hook script just to keep it in sync with the project config.

Related to PaulRBerg#60
See also juanfranblanco/vscode-solidity#463

We might recosnider the

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Added natspec comments?
  • Ran pnpm adorno?
  • Ran pnpm verify?

@3esmit 3esmit force-pushed the update-vscode-config branch from 830969d to 2ca24b1 Compare September 13, 2024 20:21
@3esmit 3esmit force-pushed the update-vscode-config branch from 2ca24b1 to 6b5f036 Compare September 13, 2024 20:34
@0x-r4bbit
Copy link
Collaborator

According to Paul's response, the nomicfoundation one is the better option...
I personally don't use vscode so I don't really have an opinion here.

Not even sure vscode settings should be part of this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

2 participants