Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.vscode/settings.json don't follow foundry docs recommendations #60

Closed
3esmit opened this issue Sep 12, 2024 · 3 comments
Closed

.vscode/settings.json don't follow foundry docs recommendations #60

3esmit opened this issue Sep 12, 2024 · 3 comments
Labels
help Extra information is needed.

Comments

@3esmit
Copy link

3esmit commented Sep 12, 2024

See https://book.getfoundry.sh/config/vscode

Maybe this is a bad recommendation on the docs. If thats the case we can add an issue at their docs.

I noticed that Nomic extension might work better than the default most popular alternative (JuanBlanco) because Nomic uses solc version from project files. I requested JuanBlanco to support solc from project files juanfranblanco/vscode-solidity#463

@PaulRBerg
Copy link
Owner

Not sure what the issue is?

Did you mean to say .vscode/settings.json instead of .vscode/attributes.json?

I wrote part of those recommendations in the Foundry docs: foundry-rs/book#750

@3esmit
Copy link
Author

3esmit commented Sep 13, 2024

I mean that docs recommends JuanBlanco formatter, and here it's using Nomic

@3esmit 3esmit changed the title .vscode/attributes.json don't follow foundry docs recommendations .vscode/settings.json don't follow foundry docs recommendations Sep 13, 2024
@PaulRBerg
Copy link
Owner

In this case, I'd recommend opening an issue/ PR in the Foundry Book repo to recommend using the Nomic extension instead.

Nomic is easier to configure and that's why I went with it (besides other benefits such as import hyperlinking).

@PaulRBerg PaulRBerg closed this as not planned Won't fix, can't repro, duplicate, stale Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help Extra information is needed.
Projects
None yet
Development

No branches or pull requests

2 participants