-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Seychelles holidays #1728
Add Seychelles holidays #1728
Conversation
Pull Request Test Coverage Report for Build 8249288462Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New country 👍
Co-authored-by: ~Jhellico <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🇸🇨 LGTM
I think you should be able to merge this by clicking "Resolve conversation" on the comment I left.
Proposed change
Add Seychelles holidays (
en_SC
,en_US
).Closes #1267.
Note
There's an incomplete list of Seychellois Creole
crs
translations for holiday names available at https://web.archive.org/web/20240312083508/https://seychellen.com/en/public-holidays/ for future improvement should we decide to implement them at a later date.Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally