Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Seychelles holidays #1267

Closed
arkid15r opened this issue Jun 3, 2023 · 6 comments · Fixed by #1728
Closed

Add Seychelles holidays #1267

arkid15r opened this issue Jun 3, 2023 · 6 comments · Fixed by #1728
Assignees

Comments

@arkid15r
Copy link
Collaborator

arkid15r commented Jun 3, 2023

Links:

@PPsyrius
Copy link
Collaborator

PPsyrius commented Dec 22, 2023

I'm working on this one, here's the actual Public Holidays Act.

@arkid15r
Copy link
Collaborator Author

Thanks a lot, @PPsyrius!

@PPsyrius
Copy link
Collaborator

PPsyrius commented Mar 1, 2024

@arkid15r Would it be possible to use subdivisions_aliases to aggregate subdivisions?

i.e.

subdivisions_aliases = {
  07: "Inner Islands"
  14: "Inner Islands"
  15: "Inner Islands"
  26: "Outer Islands"
}

@arkid15r
Copy link
Collaborator Author

arkid15r commented Mar 1, 2024

@arkid15r Would it be possible to use subdivisions_aliases to aggregate subdivisions?

i.e.

subdivisions_aliases = {
  07: "Inner Islands"
  14: "Inner Islands"
  15: "Inner Islands"
  26: "Outer Islands"
}

Not sure about this one. I checked available subdivisions here -- https://www.iso.org/obp/ui/#iso:code:3166:SC
The aliases would work for mapping names to numeric codes, e,g, Anse Boileau: "02"

It sounds like you're looking for some problem solution? Please add context details if you have any.

@PPsyrius
Copy link
Collaborator

PPsyrius commented Mar 4, 2024

@arkid15r Would it be possible to use subdivisions_aliases to aggregate subdivisions?
i.e.

subdivisions_aliases = {
  07: "Inner Islands"
  14: "Inner Islands"
  15: "Inner Islands"
  26: "Outer Islands"
}

Not sure about this one. I checked available subdivisions here -- https://www.iso.org/obp/ui/#iso:code:3166:SC The aliases would work for mapping names to numeric codes, e,g, Anse Boileau: "02"

It sounds like you're looking for some problem solution? Please add context details if you have any.

From what I understand Seychelles election take 3 days: the first day on Outer Islands, then Inner Islands, and the main island Mahé itself - as these dates has no rigid rules each subdivision need to be coded as special_public_holidays discretely. One of these cases "Inner Islands" has 3 subdivisions, so I would like to lessen code duplications here if possible.

@arkid15r
Copy link
Collaborator Author

arkid15r commented Mar 5, 2024

From what I understand Seychelles election take 3 days: the first day on Outer Islands, then Inner Islands, and the main island Mahé itself - as these dates has no rigid rules each subdivision need to be coded as special_public_holidays discretely. One of these cases "Inner Islands" has 3 subdivisions, so I would like to lessen code duplications here if possible.

Yeah, now I have better understanding of the subject. Unfortunately, subdivisions aliases mapping is on a higher abstraction level. I don't think it'll help you minimize code duplication. Maybe some common method to invoke for each subdivision?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants