Add Iran holidays #1409
Merged
Add Iran holidays #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xmha97, please look at Farsi translation, if you can. |
Pull Request Test Coverage Report for Build 5834193808
💛 - Coveralls |
arkid15r
reviewed
Aug 10, 2023
holidays/countries/iran.py
Outdated
|
|
||
| def __init__(self, *args, **kwargs): | ||
| IslamicHolidays.__init__(self) | ||
| self.pcal = _Persian() |
There was a problem hiding this comment.
I suggest using more descriptive names e.g., persian_calendar.
There was a problem hiding this comment.
You mean persian_calendar instead of pcal? Then _add_holiday(... won't fit in one line 🙄
There was a problem hiding this comment.
Yeah, Persian holidays group would help with that.
arkid15r
reviewed
Aug 11, 2023
holidays/countries/iran.py
Outdated
|
|
||
| def __init__(self, *args, **kwargs): | ||
| IslamicHolidays.__init__(self) | ||
| self.pcal = _Persian() |
There was a problem hiding this comment.
Yeah, Persian holidays group would help with that.
# Conflicts: # README.rst
# Conflicts: # holidays/holiday_groups.py
This was referenced Aug 21, 2023
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Closes #1202.
Type of change
Checklist
betabranch of the repositorymake pre-commitmake test,make tox(we strongly encourage adding tests to your code)